-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PP 353 implement the main structure for the user journey tracking #474
Merged
ValentinaIancu-Gini
merged 5 commits into
PP-349-Implement-user-journey-analysis-pipeline-in-iOS
from
PP-353-Implement-the-main-structure-for-the-user-journey-tracking
May 16, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinaIancu-Gini
force-pushed
the
PP-353-Implement-the-main-structure-for-the-user-journey-tracking
branch
2 times, most recently
from
April 17, 2024 13:35
c4a0f34
to
bad0a3e
Compare
PP-353 feat(GiniCaptureSDK): Create AnalyticsManager file to handle all analytics operations PP-353
ValentinaIancu-Gini
force-pushed
the
PP-353-Implement-the-main-structure-for-the-user-journey-tracking
branch
from
April 17, 2024 13:38
bad0a3e
to
f61ca15
Compare
zladzeyka
requested changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job,
I left some small clarification questions, ping me if more details are needed.😊
BankSDK/GiniBankSDKExample/GiniBankSDKExample/AppCoordinator.swift
Outdated
Show resolved
Hide resolved
...ces/GiniCaptureSDK/Core/Screens/Screen API Coordinator/GiniScreenAPICoordinator+Camera.swift
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Tracking/AnalyticsManager.swift
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Tracking/AnalyticsProperties.swift
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Tracking/AnalyticsScreen.swift
Outdated
Show resolved
Hide resolved
… into PP-353-Implement-the-main-structure-for-the-user-journey-tracking
…to show onboarding at launch PP-353
… into PP-353-Implement-the-main-structure-for-the-user-journey-tracking
Quality Gate passedIssues Measures |
zladzeyka
approved these changes
May 15, 2024
ValentinaIancu-Gini
merged commit May 16, 2024
1150445
into
PP-349-Implement-user-journey-analysis-pipeline-in-iOS
25 checks passed
ValentinaIancu-Gini
deleted the
PP-353-Implement-the-main-structure-for-the-user-journey-tracking
branch
May 16, 2024 06:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding the main structure for analytics to be able to start adding analytics events that we need to the user journey story.