PP 352 enables user journey analysis based on backend api #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nService Add Configuration Decodable model Add ConfigurationService, ConfigurationServiceProtocol, fetchConfiguration test func Add test endpoint to APIMethod & APIResource PP-352
Also refactor build func PP-352
resolve TODOs for APIResource & APIMethod PP-352
… into PP-352-Enables-user-journey-analysis-based-on-backend-api
…by files. make inject to GiniBankAPI optional PP-352
…enAPICoordinator custom networking viewController init PP-352
add configuration service dependency PP-352
…om networking PP-352
…rationServiceProtocol PP-352
… networking PP-352
…rotocol and add it to ConfigurationService. remove APIDomain from protocol PP-352
…Manager init PP-352
…e AnalyticsManager init to request completion PP-352
…om networking example PP-352
…rking coordinator PP-352
…ager. Add clientID super property from configuration PP-352
… into PP-352-Enables-user-journey-analysis-based-on-backend-api
|
@mrkulik thank you for your great work. I saw that I got this warning in my console: Can you please check? |
… into PP-352-Enables-user-journey-analysis-based-on-backend-api
There was a problem hiding this comment.
@mrkulik Great job.
Please see my suggestions.
I will need also to test a bit on a device.
...BankAPILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/ConfigurationService.swift
Outdated
Show resolved
Hide resolved
...BankAPILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/ConfigurationService.swift
Outdated
Show resolved
Hide resolved
...ry/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/Configuration.swift
Outdated
Show resolved
Hide resolved
BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift
Outdated
Show resolved
Hide resolved
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift
Outdated
Show resolved
Hide resolved
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift
Outdated
Show resolved
Hide resolved
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift
Outdated
Show resolved
Hide resolved
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/Networking/GiniBank+Networking.swift
Outdated
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Tracking/AnalyticsManager.swift
Show resolved
Hide resolved
…ionService PP-352
…tom networking PP-352
…actor API call completion remove extra comment, remove error, init analytics on main thread PP-352
…ntation for startSDK PP-352
...ry/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/Configuration.swift
Outdated
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Tracking/AnalyticsManager.swift
Show resolved
Hide resolved
zladzeyka
reviewed
Jun 14, 2024
...ry/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/Configuration.swift
Outdated
Show resolved
Hide resolved
...BankAPILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/ConfigurationService.swift
Outdated
Show resolved
Hide resolved
…onfigurationService PP-352
… ClientConfigurationServiceProtocol PP-352
…ConfigurationServiceProtocol PP-352
…entConfigurationServiceProtocol PP-352
There was a problem hiding this comment.
@mrkulik Thank you! we are almost there.
Please check my suggestions 🙈
...iBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/ClientConfiguration.swift
Outdated
Show resolved
Hide resolved
...ILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/ClientConfigurationService.swift
Outdated
Show resolved
Hide resolved
...ILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/ClientConfigurationService.swift
Outdated
Show resolved
Hide resolved
.../Sources/GiniBankAPILibrary/Documents/Configuration/ClientConfigurationServiceProtocol.swift
Outdated
Show resolved
Hide resolved
…ation in docs PP-352
…erviceProtocol & ClientConfigurationService PP-352
|
ValentinaIancu-Gini
approved these changes
Jun 14, 2024
mrkulik
merged commit 8a26446
into
PP-349-Implement-user-journey-analysis-pipeline-in-iOS
17 checks passed
mrkulik
deleted the
PP-352-Enables-user-journey-analysis-based-on-backend-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.