-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(GiniHealthSDK): Fix RC bugs reported #749
Conversation
…dismissal of native PDF IPC-442
…ew Screen with Multiple Pages IPC-451
…r or footer visibility IPC-450
…bank picker IPC-433
+ links color in Payment Info IPC-447
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Resources/en.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
...nalPaymentSDK/Sources/GiniInternalPaymentSDK/PaymentReview/PaymentReviewViewController.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController+Helpers.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/ScreenAPICoordinator.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/ScreenAPICoordinator.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/ScreenAPICoordinator.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/ScreenAPICoordinator.swift
Outdated
Show resolved
Hide resolved
MerchantSDK/GiniMerchantSDK/Sources/GiniMerchantSDK/Core/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razvancapra it's looking good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razvancapra pr looks good!
…rom payment review screen IPC-433
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razvancapra new changes are looking good.
- breaking change in `NSMutableAttributedString` extension for public method `addLinkToRange`
- new method added in public protocol `paymentReviewClosed(with previousPresentedView: PaymentComponentScreenType?)`
|
IPC-447
IPC-485
IPC-449
IPC-433
IPC-450
IPC-451
IPC-442
IPC-443
Bugs solved in this PR:
https://ginis.atlassian.net/browse/IPC-447
https://ginis.atlassian.net/browse/IPC-485
https://ginis.atlassian.net/browse/IPC-449
https://ginis.atlassian.net/browse/IPC-433
https://ginis.atlassian.net/browse/IPC-450
https://ginis.atlassian.net/browse/IPC-451
https://ginis.atlassian.net/browse/IPC-442
https://ginis.atlassian.net/browse/IPC-443