-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pp 932 i os add a transfer summary method with document id instead of sending the entire document object #750
Conversation
...Library/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/DefaultDocumentService.swift
Outdated
Show resolved
Hide resolved
...Library/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/DefaultDocumentService.swift
Outdated
Show resolved
Hide resolved
...Library/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/DefaultDocumentService.swift
Outdated
Show resolved
Hide resolved
...Library/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/DefaultDocumentService.swift
Outdated
Show resolved
Hide resolved
...Library/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/DefaultDocumentService.swift
Outdated
Show resolved
Hide resolved
...Library/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/DefaultDocumentService.swift
Outdated
Show resolved
Hide resolved
...Library/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/DefaultDocumentService.swift
Outdated
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Networking/GiniCaptureNetworkService.swift
Show resolved
Hide resolved
…PP-932-iOS-Add-a-transfer-summary-method-with-documentId-instead-of-sending-the-entire-document-object # Conflicts: # CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Networking/DocumentService.swift
… and refactor methods to multiline params PP-932
… sendFeedback with documentId PP-932
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrkulik nice work. Can you please check my suggestions?
...Library/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/DefaultDocumentService.swift
Show resolved
Hide resolved
...Library/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/DefaultDocumentService.swift
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Networking/GiniCaptureNetworkService.swift
Outdated
Show resolved
Hide resolved
…documentId) PP-932
…documentId, compoundExtractions) PP-932
…for submitFeedback(for documentId, compoundExtractions) PP-932
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrkulik Thank you! Looks good to me now.
No description provided.