Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pp 932 i os add a transfer summary method with document id instead of sending the entire document object #750

Conversation

mrkulik
Copy link
Contributor

@mrkulik mrkulik commented Dec 4, 2024

No description provided.

@mrkulik mrkulik self-assigned this Dec 4, 2024
…PP-932-iOS-Add-a-transfer-summary-method-with-documentId-instead-of-sending-the-entire-document-object

# Conflicts:
#	CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Networking/DocumentService.swift
… and refactor methods to multiline params

PP-932
Copy link
Contributor

@ValentinaIancu-Gini ValentinaIancu-Gini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrkulik nice work. Can you please check my suggestions?

Copy link
Contributor

@ValentinaIancu-Gini ValentinaIancu-Gini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrkulik Thank you! Looks good to me now.

Base automatically changed from PP-615-iOS-Implement-Transfer-Summary-for-Skonto to Release-3.13.0 December 10, 2024 11:51
@ValentinaIancu-Gini ValentinaIancu-Gini merged commit e6aacec into Release-3.13.0 Dec 10, 2024
35 checks passed
@ValentinaIancu-Gini ValentinaIancu-Gini deleted the PP-932-iOS-Add-a-transfer-summary-method-with-documentId-instead-of-sending-the-entire-document-object branch December 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants