Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pp 615 skonto transfer summary integration tests #754

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Pp 615 skonto transfer summary integration tests #754

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6dcb3b
feat(GiniBankSDKExample): SkontoTransferSummaryIntegrationTest. Updat…
mrkulik Dec 6, 2024
2b86360
feat(GiniBankSDKExample): SkontoTransferSummaryIntegrationTest optimi…
mrkulik Dec 6, 2024
4493dca
Merge branch 'PP-615-iOS-Implement-Transfer-Summary-for-Skonto' into …
mrkulik Dec 9, 2024
d31640b
feat(GiniBankSDKExample): Update integration tests after merge. Forma…
mrkulik Dec 9, 2024
d857fdb
feat(GiniBankSDKExample): rename applySkontoAdjustmentsIfNeeded -> ap…
mrkulik Dec 9, 2024
536c300
feat(GiniBankSDKExample): SkontoTransferSummaryIntegrationTest: remov…
mrkulik Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions BankSDK/GiniBankSDKExample/GiniBankSDKExample.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,11 @@
847B68CA2C4009FA00544050 /* CustomSkontoBottomNavigationBar.swift in Sources */ = {isa = PBXBuildFile; fileRef = 847B68C92C4009FA00544050 /* CustomSkontoBottomNavigationBar.swift */; };
847B68CC2C400A0600544050 /* CustomSkontoBottomNavigationBarAdapter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 847B68CB2C400A0600544050 /* CustomSkontoBottomNavigationBarAdapter.swift */; };
84C53D5E2C87477D00A908BB /* AttachmentsTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 84C53D5D2C87477D00A908BB /* AttachmentsTableViewCell.swift */; };
84C5D65C2D0240E7005711C5 /* result_Gini_invoice_example_skonto_after_transfer_summary.json in Resources */ = {isa = PBXBuildFile; fileRef = 84C5D65B2D0240E7005711C5 /* result_Gini_invoice_example_skonto_after_transfer_summary.json */; };
84C5D65D2D0240E7005711C5 /* result_Gini_invoice_example_skonto_after_transfer_summary.json in Resources */ = {isa = PBXBuildFile; fileRef = 84C5D65B2D0240E7005711C5 /* result_Gini_invoice_example_skonto_after_transfer_summary.json */; };
84CD074D2C7DBB9A004DF1DE /* CustomDigitalInvoiceSkontoBottomNavigationBar.swift in Sources */ = {isa = PBXBuildFile; fileRef = 84CD074C2C7DBB9A004DF1DE /* CustomDigitalInvoiceSkontoBottomNavigationBar.swift */; };
84CD074F2C7DBBAD004DF1DE /* CustomDigitalInvoiceSkontoBottomNavigationBarAdapter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 84CD074E2C7DBBAD004DF1DE /* CustomDigitalInvoiceSkontoBottomNavigationBarAdapter.swift */; };
84DB5EA22D03172E005EDC4C /* SkontoTransferSummaryIntegrationTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 84DB5EA12D03172E005EDC4C /* SkontoTransferSummaryIntegrationTest.swift */; };
84F2FD142CD0FABC00DAE5B4 /* SettingsHeaderView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 84F2FD132CD0FABC00DAE5B4 /* SettingsHeaderView.swift */; };
84F2FD172CD0FAC600DAE5B4 /* SettingsSection.swift in Sources */ = {isa = PBXBuildFile; fileRef = 84F2FD152CD0FAC600DAE5B4 /* SettingsSection.swift */; };
84F2FD182CD0FAC600DAE5B4 /* SettingsViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 84F2FD162CD0FAC600DAE5B4 /* SettingsViewModel.swift */; };
Expand Down Expand Up @@ -273,8 +276,10 @@
847B68C92C4009FA00544050 /* CustomSkontoBottomNavigationBar.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CustomSkontoBottomNavigationBar.swift; sourceTree = "<group>"; };
847B68CB2C400A0600544050 /* CustomSkontoBottomNavigationBarAdapter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CustomSkontoBottomNavigationBarAdapter.swift; sourceTree = "<group>"; };
84C53D5D2C87477D00A908BB /* AttachmentsTableViewCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AttachmentsTableViewCell.swift; sourceTree = "<group>"; };
84C5D65B2D0240E7005711C5 /* result_Gini_invoice_example_skonto_after_transfer_summary.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = result_Gini_invoice_example_skonto_after_transfer_summary.json; sourceTree = "<group>"; };
84CD074C2C7DBB9A004DF1DE /* CustomDigitalInvoiceSkontoBottomNavigationBar.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CustomDigitalInvoiceSkontoBottomNavigationBar.swift; sourceTree = "<group>"; };
84CD074E2C7DBBAD004DF1DE /* CustomDigitalInvoiceSkontoBottomNavigationBarAdapter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CustomDigitalInvoiceSkontoBottomNavigationBarAdapter.swift; sourceTree = "<group>"; };
84DB5EA12D03172E005EDC4C /* SkontoTransferSummaryIntegrationTest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SkontoTransferSummaryIntegrationTest.swift; sourceTree = "<group>"; };
84F2FD132CD0FABC00DAE5B4 /* SettingsHeaderView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SettingsHeaderView.swift; sourceTree = "<group>"; };
84F2FD152CD0FAC600DAE5B4 /* SettingsSection.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SettingsSection.swift; sourceTree = "<group>"; };
84F2FD162CD0FAC600DAE5B4 /* SettingsViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SettingsViewModel.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -435,6 +440,7 @@
children = (
28D77C3E2CBE99FC00F815DB /* Gini_invoice_example_skonto.pdf */,
28D77C3F2CBE99FC00F815DB /* result_Gini_invoice_example_skonto.json */,
84C5D65B2D0240E7005711C5 /* result_Gini_invoice_example_skonto_after_transfer_summary.json */,
);
path = Skonto;
sourceTree = "<group>";
Expand Down Expand Up @@ -500,6 +506,7 @@
children = (
28D77C592CBEA8B100F815DB /* BaseIntegrationTest+TransferSummary.swift */,
F45D7F002800566900C73C63 /* TransferSummaryIntegrationTest.swift */,
84DB5EA12D03172E005EDC4C /* SkontoTransferSummaryIntegrationTest.swift */,
);
path = TransferSummary;
sourceTree = "<group>";
Expand Down Expand Up @@ -999,6 +1006,7 @@
28D77C542CBE99FC00F815DB /* result_Gini_invoice_example_line_items_with_discount.json in Resources */,
28B5874D2A374730008CB210 /* SegmentedOptionTableViewCell.xib in Resources */,
289D3DB42A4EC857002A6681 /* InfoTableViewCell.xib in Resources */,
84C5D65C2D0240E7005711C5 /* result_Gini_invoice_example_skonto_after_transfer_summary.json in Resources */,
8303F4EF28F9AD7700285599 /* magicAnimation.json in Resources */,
83D02CD7290AC43E00DA97F7 /* CustomOnboardingBottomNavigationBar.xib in Resources */,
F45D7F192800583800C73C63 /* Gini_invoice_example.pdf in Resources */,
Expand Down Expand Up @@ -1035,6 +1043,7 @@
F45D7F132800566900C73C63 /* result_Gini_invoice_example_after_feedback.json in Resources */,
F45D7F102800566900C73C63 /* result_Gini_invoice_example.json in Resources */,
F45D7F112800566900C73C63 /* testPDF.pdf in Resources */,
84C5D65D2D0240E7005711C5 /* result_Gini_invoice_example_skonto_after_transfer_summary.json in Resources */,
28D77C4F2CBE99FC00F815DB /* result_Gini_invoice_example_payment_reference_after_feedback.json in Resources */,
28D77C512CBE99FC00F815DB /* result_Gini_invoice_example_payment_reference.json in Resources */,
287068462CB9519000D5F2C9 /* result_Gini_invoice_example_RA_Skonto.json in Resources */,
Expand Down Expand Up @@ -1168,6 +1177,7 @@
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
84DB5EA22D03172E005EDC4C /* SkontoTransferSummaryIntegrationTest.swift in Sources */,
28B203FF2BB2E78B00C78740 /* FileLoader.swift in Sources */,
F45D7F0E2800566900C73C63 /* ScreenAPICoordinator+UI_Only.swift in Sources */,
28D77C582CBEA85100F815DB /* BaseIntegrationTest+Skonto.swift in Sources */,
Expand Down
31 changes: 8 additions & 23 deletions BankSDK/GiniBankSDKExample/Tests/IntegrationTests/Base/BaseIntegrationTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ class BaseIntegrationTest: XCTestCase {
*/
func uploadAndAnalyzeDocument(fileName: String,
delegate: GiniCaptureResultsDelegate,
documentType: String = "pdf",
sendTransferSummaryIfNeeded: Bool = false) {
documentType: String = "pdf") {
guard let testDocumentData = FileLoader.loadFile(withName: fileName,
ofType: documentType) else {
XCTFail("Error loading file: `\(fileName).\(documentType)`")
Expand All @@ -49,8 +48,7 @@ class BaseIntegrationTest: XCTestCase {
switch result {
case .success(_):
self.handleUploadSuccess(captureDocument: captureDocument,
delegate: delegate,
sendTransferSummaryIfNeeded: sendTransferSummaryIfNeeded)
delegate: delegate)
case let .failure(error):
XCTFail(String(describing: error))
}
Expand All @@ -66,14 +64,12 @@ class BaseIntegrationTest: XCTestCase {
- sendTransferSummaryIfNeeded: A Boolean flag indicating whether to send a transfer summary after analysis.
*/
func handleUploadSuccess(captureDocument: GiniCaptureDocument,
delegate: GiniCaptureResultsDelegate,
sendTransferSummaryIfNeeded: Bool) {
delegate: GiniCaptureResultsDelegate) {
giniHelper.giniCaptureSDKDocumentService?.startAnalysis { result in
switch result {
case let .success(extractionResult):
self.handleAnalysisSuccess(extractionResult: extractionResult,
delegate: delegate,
sendTransferSummaryIfNeeded: sendTransferSummaryIfNeeded)
delegate: delegate)
case let .failure(error):
XCTFail(String(describing: error))
}
Expand All @@ -89,34 +85,23 @@ class BaseIntegrationTest: XCTestCase {
- sendTransferSummaryIfNeeded: A Boolean flag indicating whether to send a transfer summary after analysis.
*/
func handleAnalysisSuccess(extractionResult: ExtractionResult,
delegate: GiniCaptureResultsDelegate,
sendTransferSummaryIfNeeded: Bool) {
delegate: GiniCaptureResultsDelegate) {
let extractions: [String: Extraction] = Dictionary(uniqueKeysWithValues: extractionResult.extractions.compactMap {
guard let name = $0.name else { return nil }
return (name, $0)
})

let analysisResult = AnalysisResult(extractions: extractions,
lineItems: extractionResult.lineItems,
skontoDiscounts: extractionResult.skontoDiscounts,
images: [],
document: self.giniHelper.giniCaptureSDKDocumentService?.document,
candidates: [:])

self.analysisExtractionResult = extractionResult
delegate.giniCaptureAnalysisDidFinishWith(result: analysisResult)
GiniBankConfiguration.shared.lineItems = extractionResult.lineItems

if sendTransferSummaryIfNeeded {
// Send transfer summary for the extractions the user confirmed
GiniBankConfiguration.shared.sendTransferSummary(
paymentRecipient: extractions["paymentRecipient"]?.value ?? "",
paymentReference: extractions["paymentReference"]?.value ?? "",
paymentPurpose: extractions["paymentPurpose"]?.value ?? "",
iban: extractions["iban"]?.value ?? "",
bic: extractions["bic"]?.value ?? "",
amountToPay: ExtractionAmount(value: 950.00, currency: .EUR)
)
}
GiniBankConfiguration.shared.skontoDiscounts = extractionResult.skontoDiscounts
delegate.giniCaptureAnalysisDidFinishWith(result: analysisResult)
}

/**
Expand Down
10 changes: 5 additions & 5 deletions ...KExample/Tests/IntegrationTests/TransferSummary/BaseIntegrationTest+TransferSummary.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import XCTest
extension BaseIntegrationTest {

// Method to handle updating and verifying feedback
func updateAndVerifyTransferSummary(result: AnalysisResult, expect: XCTestExpectation) {
func updateAndVerifyTransferSummary(result: AnalysisResult, mockedInvoiceUpdatedResultName: String, expect: XCTestExpectation) {
// Assuming the user updated the amountToPay to "950.00:EUR"
result.extractions["amountToPay"]?.value = "950.00:EUR"

Expand All @@ -25,6 +25,7 @@ extension BaseIntegrationTest {
switch updatedResult {
case let .success(extractionResult):
self.handleSuccessfulTransferSummaryUpdate(extractionResult: extractionResult,
mockedInvoiceUpdatedResultName: mockedInvoiceUpdatedResultName,
expect: expect,
result: result)
case let .failure(error):
Expand All @@ -44,13 +45,12 @@ extension BaseIntegrationTest {
- result: The initial analysis result.
*/
private func handleSuccessfulTransferSummaryUpdate(extractionResult: ExtractionResult,
mockedInvoiceUpdatedResultName: String,
expect: XCTestExpectation,
result: AnalysisResult) {
let extractionsAfterFeedback = extractionResult.extractions

let mockedInvoice = "result_Gini_invoice_example_payment_reference_after_feedback"
// Load the expected fixture after feedback
guard let fixtureExtractionsAfterFeedbackContainer = self.loadFixtureExtractionsContainer(from: mockedInvoice) else {
guard let fixtureExtractionsAfterFeedbackContainer = self.loadFixtureExtractionsContainer(from: mockedInvoiceUpdatedResultName) else {
return
}

Expand Down Expand Up @@ -91,7 +91,7 @@ extension BaseIntegrationTest {
* This method reproduces getting updated extractions for the already known document by the Bank SDK.
* It is assumed that transfer summary was sent, and we retrieve the updated extractions for verification.
*/
private func getUpdatedExtractionsFromGiniBankSDK(for document: Document, completion: @escaping AnalysisCompletion) {
func getUpdatedExtractionsFromGiniBankSDK(for document: Document, completion: @escaping AnalysisCompletion) {
self.giniHelper.giniBankAPIDocumentService.extractions(for: document,
cancellationToken: CancellationToken()) { result in
switch result {
Expand Down
Loading