Gini bank sdk xc frameworks bash script #761
Conversation
…building via script
…t Pinning - xcframeworks generated with this script are working - tested
…ean xcframeworks on startup
…s and clean xcframeworks on startup" This reverts commit a7ed49c.
…i/gini-mobile-ios into GiniBankSDK-XCFrameworks-bash-script
|
|
@zladzeyka, the duplication of code that Sonarcloud is complaining about is the color files from both Capture and Bank SDK. I will ignore this since there is nothing that I can do right now. |
There was a problem hiding this comment.
Thank you @ValentinaIancu-Gini
Left a couple of clarifying questions only.
There was a problem hiding this comment.
[Clarification]: Could you please investigate if we need to commit this .resolved file?
|
|
||
| 2. In terminal open the newly generated project `open .build/swift-create-xcframework/GiniBankSDK.xcodeproj` | ||
| ## Using XCFrameworks in a tetsing project |
There was a problem hiding this comment.
| ## Using XCFrameworks in a tetsing project | |
| ## Using XCFrameworks in a testing project |
| ], | ||
| targets: [ | ||
| // Targets are the basic building blocks of a package. A target can define a module or a test suite. | ||
| // Targets can depend on other targets in this package, and on products in packages this package depends on. | ||
|
|
||
| .target( | ||
| name: "GiniBankSDK", | ||
| dependencies: ["GiniCaptureSDK"]), | ||
| dependencies: ["GiniCaptureSDK", "GiniBankAPILibrary"]), |
There was a problem hiding this comment.
[Clarification]: Are you sure that we need to include the dependency GiniBankAPILibrary here?
| @@ -17,14 +17,15 @@ let package = Package( | |||
| // Dependencies declare other packages that this package depends on. | |||
| // .package(url: /* package url */, from: "1.0.0"), | |||
| .package(name: "GiniCaptureSDK", url: "https://github.com/gini/capture-sdk-ios.git", .exact("3.11.0")), | |||
| .package(name: "GiniBankAPILibrary", url: "https://github.com/gini/bank-api-library-ios.git", .exact("3.4.0")) | |||
There was a problem hiding this comment.
[Clarification]@ValentinaIancu-Gini this file is used in SPM only and not for XCFrameworks, are you sure that we need GiniBankAPILibrary here?
| @@ -17,15 +17,17 @@ let package = Package( | |||
| // Dependencies declare other packages that this package depends on. | |||
| // .package(url: /* package url */, from: "1.0.0"), | |||
| .package(name: "GiniCaptureSDKPinning", url: "https://github.com/gini/capture-sdk-pinning-ios.git", .exact("3.11.0")), | |||
| .package(name: "GiniBankAPILibraryPinning", url: "https://github.com/gini/bank-api-library-pinning-ios.git", .exact("3.4.0")), | |||
There was a problem hiding this comment.
[Clarification]: This file will be used for SPM only, shall we keep those changes?
| @@ -11,21 +12,29 @@ let package = Package( | |||
| // Products define the executables and libraries a package produces, and make them visible to other packages. | |||
| .library( | |||
| name: "GiniBankSDKPinning", | |||
| type: ProcessInfo.processInfo.environment["GINI_FORCE_DYNAMIC_LIBRARY"] == "1" ? .dynamic : nil, | |||
There was a problem hiding this comment.
[Clarification]: what do we achive with this flag " GINI_FORCE_DYNAMIC_LIBRARY"?
This pr dosen't take into consideration Pinning SDKs with the TrustKit framework.