Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pp 194 merge capture sdk example app into bank sdk example app #763

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ValentinaIancu-Gini
Copy link
Contributor

Remove all the example projects for: Capture, CapturePinning, APILIbrary, and APILIbraryPinning.
All the tests were moved accordingly except the transfer summary tests which were refactored and already contain what we need to test.

Copy link
Collaborator

@zladzeyka zladzeyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValentinaIancu-Gini thank you.
Looks good to me, let's just wait a bit for a merging it in main

@zladzeyka zladzeyka self-requested a review February 3, 2025 16:46
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
34.5% Duplication on New Code (required ≤ 3%)
16 New Code Smells (required ≤ 0)
8 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants