iPhone landscape support #764
Conversation
igor-gini
changed the title
igor-gini
force-pushed
the
iphone-landscape-orientation-support
branch
from
3032c97 to
1024084
Compare
…, album picker screen, photo selector screen; fix camera crashing for ipad PP-943
…s and ipad, help screens
igor-gini
force-pushed
the
iphone-landscape-orientation-support
branch
from
2a11e17 to
f482cb1
Compare
There was a problem hiding this comment.
Thank you @igor-gini
I left some comments here. I didn't check the bottom navigation yet, I'll check it as you're done with suggestions
| @@ -28,6 +28,7 @@ extension UITableViewCell { | |||
|
|
|||
| public struct GiniMargins { | |||
| public static let margin: CGFloat = 16 | |||
| public static let marginHorizontal: CGFloat = 56 | |||
There was a problem hiding this comment.
| public static let marginHorizontal: CGFloat = 56 | |
| public static let horizontalMargin: CGFloat = 56 |
There was a problem hiding this comment.
we need to consider Dynamic Island here
There was a problem hiding this comment.
Basically, you just need to anchor elements horizontally not to the view itself, but to its safeAreaLayoutGuide, and then use leadingAnchor/trailingAnchor from it as needed. That way, it will be attached to the safe area.
There was a problem hiding this comment.
- current implementation
and expected one: https://www.figma.com/design/ZYpdKfpaHOpV7RV1TTWdEH/Gini-Photo-Payment%3A-iOS-%26-Android?node-id=8819-39107&t=tQMSP1LmaMr0kGxk-1
...SDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Analysis/AnalysisViewController.swift
Outdated
Show resolved
Hide resolved
...SDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Analysis/AnalysisViewController.swift
Show resolved
Hide resolved
| @@ -71,7 +71,6 @@ class OnboardingViewController: UIViewController { | |||
| NSLayoutConstraint.activate([ | |||
| navigationBar.topAnchor.constraint(equalTo: pageControl.bottomAnchor, constant: 46), | |||
There was a problem hiding this comment.
@igor-gini please wrap it in Constants
| pageControl.bottomAnchor.constraint(equalTo: contentView.bottomAnchor, constant: -Constants.padding * 2), | ||
| pageControl.topAnchor.constraint(equalTo: collectionView.bottomAnchor, constant: Constants.padding * 2), | ||
| pageControl.leadingAnchor.constraint(equalTo: contentView.leadingAnchor), | ||
| pageControl.trailingAnchor.constraint(equalTo: contentView.trailingAnchor, constant: -275) |
There was a problem hiding this comment.
@igor-gini please wrap it in Constant
| @@ -272,6 +278,18 @@ public final class ReviewViewController: UIViewController { | |||
| buttonContainer.leadingAnchor.constraint(greaterThanOrEqualTo: view.leadingAnchor) | |||
| ] | |||
|
|
|||
| private lazy var buttonContainerHorizontalConstraints: [NSLayoutConstraint] = [ | |||
| buttonContainer.trailingAnchor.constraint(equalTo: view.trailingAnchor, constant: -85), | |||
There was a problem hiding this comment.
@igor-gini please wrap it in Constants
| bottomNavigationBar?.alpha = isLandscape ? 0 : 1 | ||
| bottomNavigationBar?.isUserInteractionEnabled = !isLandscape | ||
|
|
||
| trailingConstraints.forEach { $0.constant = isLandscape ? -275 : 0 } |
There was a problem hiding this comment.
@igor-gini please wrap it in Constants
There was a problem hiding this comment.
@igor-gini Could you please wrap the magic numbers in the Constants?
Our file is getting too big, can we extract something in extension and move it to a new file?
Currently if I add 3 images scrollview is not positioned correctly could you please adjust it as we have here https://www.figma.com/design/ZYpdKfpaHOpV7RV1TTWdEH/Gini-Photo-Payment%3A-iOS-%26-Android?node-id=9243-41741&t=RYL3FUZBCL6TItSy-1
There was a problem hiding this comment.
I didn’t quite understand the ScrollView positioning here. In the code, I see that it highlights the last captured photo after shooting, but should it be the second-to-last one? Or how is it supposed to work?
…er bottom bar for small iphones
|
No description provided.