refactor(documentation): partie 7, Rating, modèle, migration et vue #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
added
python
vincentporte
force-pushed
the
765-part7
branch
2 times, most recently
from
07734c7
to
d2aa52d
Compare
vincentporte
requested review from
francoisfreitag,
calummackervoy and
hellodeloo
vincentporte
force-pushed
the
765-part7
branch
from
c6146a0
to
d2aa52d
Compare
| response = client.post(url, data={"rating": 5}) | ||
| assert response.status_code == 200 | ||
| assert response.context["count"] == 6 | ||
| assert response.context["average"] == 3 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Ah, trop rapide. J’avais pas vu le post qui en créait un supplémentaire.
| document=get_object_or_404(Document, pk=self.kwargs["pk"]), | ||
| user=request.user if request.user.is_authenticated else None, | ||
| rating=int(request.POST["rating"]), | ||
| session_id=request.session.session_key, |
There was a problem hiding this comment.
C’est pas nouveau, mais facile de pourrir vos stats 😇
| document_rating = DocumentRating.objects.create( | ||
| document=get_object_or_404(Document, pk=self.kwargs["pk"]), | ||
| user=request.user if request.user.is_authenticated else None, | ||
| rating=int(request.POST["rating"]), |
There was a problem hiding this comment.
Est-ce qu’on ne voudrait pas au moins contrôler que c’est dans l’intervalle [0-5] ?
vincentporte
force-pushed
the
765-part6
branch
from
1286377
to
506d51b
Compare
…ment and a specified session key
vincentporte
force-pushed
the
765-part7
branch
from
d2aa52d
to
dfefbaf
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #765
Description
🎸 Migrer
ForumRatingdansDocumentRating🎸 Adapter la vue
htmxType de changement
🚧 technique
Points d'attention
🦺
ForumRatingest associé àrequest.session.session_key. Si unForumRatingexiste déjà,DocumentDetailViewaffiche leForumRatingobtenu à la place des boutons d'évaluations.🦺 ajout de 2 annotations
countetaveragepour un rendu plus interessant (opportunité)🦺 suite #791
Captures d'écran (optionnel)
Avant votation
Après votation