fix: filtrage des questions en utilisant les étiquettes #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
force-pushed
the
vp/fix_tag_filtering
branch
from
fd36aac
to
d61afd3
Compare
| def test_clickable_tags(self, client, db, snapshot): | ||
| @pytest.mark.parametrize( | ||
| "num_of_topics_before_tagged_topic,query_param,snapshot_name", | ||
| [(None, None, "clickable_tags_page1"), (10, "?page=2", "clickable_tags_page2")], |
There was a problem hiding this comment.
Pour te faciliter la vie, tu pourrais définir les query params vide avec "". 🤷
| @@ -190,32 +190,26 @@ | |||
| ''' | |||
| # --- | |||
| # name: TestTopicListView.test_clickable_tags[10-?page=2-clickable_tags_page2][clickable_tags_page2] | |||
| '<a class="tag bg-info-lighter text-info" href="/topics/?tag=tag&filter=">tag</a>' | |||
| '<button class="tag bg-info-lighter text-info matomo-event" data-matomo-action="filter" data-matomo-category="engagement" data-matomo-option="topics" hx-get="/topics/?tag=tag&filter=" hx-push-url="true" hx-swap="outerHTML" hx-target="#topicsarea" id="filtertopics-button">tag</button>' | |||
There was a problem hiding this comment.
Laisser un a permettrait d’ouvrir les pages dans des onglets.
vincentporte
added a commit
that referenced
this pull request
Oct 9, 2024
🦺 suite #794. fusion avant d'avoir poussé le rebasage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifications principales, dans le gabarit
lacommunaute/templates/forum_conversation/partials/topic_tags.html🎸 suppression du paramètre
page=1qui forçait le masquage de la zone de filtre🎸 appel
htmxdeTopicListViewlors du clic sur les tags, pour éviter tous les inconvénients d'un rechargement de page completPetits bonus en passant
🎸 fiabilisation des tests sur les filtres x les étiquettes
🎸 desambiguation des paramètres dans le contexte de la vue
TopicListView🎸 suppression de la gestion d'une liste de
Tagdans les url (non terminé), pour n'en gérer plus qu'un seulType de changement
🪲 Correction de bug (changement non cassant qui corrige un problème).
🎨 changement d'UI
🚧 technique
Points d'attention
🦺 réécriture des tests concernés dans les commits pour améliorer la lisibilité (voir les passer en style
pytest)🦺 renommage des énums pour une meilleure présentation utilisateur
🦺 réécriture des tests de
ForumViewà voir ultérieurement selon les impacts de l'issue #765Captures d'écran (optionnel)
filtrage
ALLfiltrage
ALLx étiquettefiltrage
NEWfiltrage
NEWx étiquettefiltrage
CERTIFIEDfiltrage
CERTIFIEDx étiquette