tests: remove duplicate redirect assertions

`assertRedirects` verifies the status code as well as the redirect URL. Therefore, prefer `assertRedirects` over `assert response.status_code == 302` or `assert response.url == next_url`.
gip-inclusion · Feb 5, 2025 · 0b10a54 · 0b10a54
1 parent be10a05
commit 0b10a54
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 135 deletions.
diff --git a/tests/gps/test_create_beneficiary.py b/tests/gps/test_create_beneficiary.py
@@ -263,7 +263,6 @@ def test_existing_user_with_email(client):
         },
     }
 
-    assert response.url == next_url
     assert client.session[job_seeker_session_name] == expected_job_seeker_session
     assertRedirects(response, next_url)
-Original file line number
+Diff line change
@@ Expand Up / @@ -263,7 +263,6 @@ def test_existing_user_with_email(client): @@
             },
         }
-        assert response.url == next_url
         assert client.session[job_seeker_session_name] == expected_job_seeker_session
         assertRedirects(response, next_url)
@@ Expand Down @@