-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(billing): Implement last month usage charging on subscription cancellation #296
Merged
gentamura
merged 10 commits into
main
from
feat/charge-last-month-usage-on-subscription-deletion
Feb 7, 2025
+24
−17
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0047639
feat(billing): Handle timestamp differently for test clock simulation
gentamura 1bcb884
refactor(webhook): Simplify invoice creation handling for canceled su…
gentamura edfa1aa
refactor(webhook): Improve invoice creation handler with better error…
gentamura 6ddee1e
fix(webhook): Add subscription update after cancellation
gentamura 49b2633
Remove a comment
gentamura 262e2c8
Merge branch 'main' into feat/charge-last-month-usage-on-subscription…
gentamura 99f4255
Merge branch 'main' into feat/charge-last-month-usage-on-subscription…
gentamura 701c473
Merge branch 'main' into feat/charge-last-month-usage-on-subscription…
gentamura 9ba3e19
refactor(stripe): simplify invoice payment process
gentamura 0ff5641
Add comments
gentamura File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { stripe } from "@/services/external/stripe"; | ||
import type Stripe from "stripe"; | ||
|
||
export async function handleInvoiceCreation(invoice: Stripe.Invoice) { | ||
if (!invoice.subscription || typeof invoice.subscription !== "string") { | ||
throw new Error( | ||
"Invoice is missing a subscription ID. Please check the invoice data.", | ||
); | ||
} | ||
|
||
const subscription = await stripe.subscriptions.retrieve( | ||
invoice.subscription, | ||
); | ||
|
||
if (subscription.status !== "canceled") { | ||
return; | ||
} | ||
|
||
// When a subscription is canceled, we should charge for usage-based billing from the previous billing cycle. The final invoice, which includes these charges, will be automatically created but will not be processed for payment. Therefore, we need to handle this case manually. | ||
await stripe.invoices.pay(invoice.id); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 When a subscription expires and the subscription is cancelled,
customer.subscription.updated
does not fire, so the above method is executed oncustomer.subscription.deleted
and the database is updated appropriately.