Skip to content

Commit

Permalink
Git GUI: fix Repository>Explore Working Copy (#4357)
Browse files Browse the repository at this point in the history
This is a companion PR of prati0100/git-gui#95

Since Git v2.39.1, we are a bit more stringent in searching the PATH. In
particular, we specifically require the `.exe` suffix.

However, the `Repository>Explore Working Copy` command asks for
`explorer.exe` to be found on the `PATH`, which _already_ has that
suffix.

Let's unstartle the PATH-finding logic about this scenario.

This fixes #4356
  • Loading branch information
dscho authored and Git for Windows Build Agent committed Mar 22, 2023
2 parents 8b9f802 + 4b29518 commit 860e7f9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions git-gui/git-gui.sh
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ proc _which {what args} {
if {[is_Windows] && [lsearch -exact $args -script] >= 0} {
set suffix {}
} elseif {[string match *$_search_exe $what]} {
# The search string already has the file extension
set suffix {}
} else {
set suffix $_search_exe
}
Expand Down

0 comments on commit 860e7f9

Please sign in to comment.