Skip to content

Commit

Permalink
chore: add PR checklist to pr template (#2434)
Browse files Browse the repository at this point in the history
  • Loading branch information
vacekj authored Oct 10, 2023
1 parent a717d65 commit 4572749
Showing 1 changed file with 21 additions and 5 deletions.
26 changes: 21 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,30 @@ Thank you for your pull request! Please review the requirements below
and ensure your pull request has fulfilled all requirements outlined in the target package.
-->

## PR checklist

For every PR, make sure that these statements are true:
- [ ] Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
- [ ] Doesn't contain type casts and non-null assertions.
- [ ] Doesn't add `@ts-ignore`.
- [ ] Doesn't disable lints.
- [ ] Doesn't use `useState` just for computation - use plain variables instead.
- [ ] Splits components into pure components that don't depend on external state or hooks.
- [ ] Avoid embedding components within other components
- [ ] Doesn't propagate optional values without good reason, doesn't mark property values as optional if that doesn't represent reality.
- [ ] Doesn't duplicate existing code.
- [ ] Parses out-of-domain data - this includes user input, API respones, on-chain data etc.
- [ ] Doesn't contain commented out code.
- [ ] Doesn't contain skipped or empty tests.

Subjective - at the discretion of the reviewers
- Does things as simply as possible, but not simpler.
- Doesn't reinvent the wheel or create premature abstractions.

##### Description

<!-- Describe your changes here. -->

##### Refers/Fixes

<!-- If this PR is related to a GitHub issue, please add a link here. -->

##### Testing

<!-- All PRs should be accompanied by tests! If you haven't added tests, please explain here. -->
fixes #issuenumber

5 comments on commit 4572749

@vercel
Copy link

@vercel vercel bot commented on 4572749 Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

manager – ./packages/round-manager

manager-git-main-grants-stack.vercel.app
manager-grants-stack.vercel.app
manager.gitcoin.co
grants-stack-round-manager.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 4572749 Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

manager-staging – ./packages/round-manager

manager-staging.vercel.app
manager-staging-git-main-grants-stack.vercel.app
manager-staging-grants-stack.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 4572749 Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

builder – ./packages/builder

builder-kappa-one.vercel.app
builder-git-main-grants-stack.vercel.app
builder-grants-stack.vercel.app
builder.gitcoin.co

@vercel
Copy link

@vercel vercel bot commented on 4572749 Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

explorer-staging – ./packages/grant-explorer

explorer-staging-grants-stack.vercel.app
explorer-staging-git-main-grants-stack.vercel.app
grants-stack-grant-explorer-ten.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 4572749 Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

builder-staging – ./packages/builder

builder-staging-git-main-grants-stack.vercel.app
builder-staging-grants-stack.vercel.app
builder-staging-xi.vercel.app

Please sign in to comment.