Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update contributing docs #2440

Merged
merged 7 commits into from
Oct 17, 2023
Merged

docs: update contributing docs #2440

merged 7 commits into from
Oct 17, 2023

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Oct 9, 2023 •
edited
Loading

fixes #2431
fixes #2461

@vacekj vacekj requested a review from a team as a code owner October 9, 2023 16:59
@vacekj vacekj linked an issue Oct 9, 2023 that may be closed by this pull request
Update contributing.md #2431
Closed
@vacekj vacekj requested review from a team as code owners October 9, 2023 16:59
@vacekj vacekj removed request for a team October 9, 2023 16:59
@vercel
Copy link

vercel bot commented Oct 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 10:08am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 10:08am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 10:08am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 10:08am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 10:08am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 10:08am

bard
bard previously approved these changes Oct 10, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/DEV.md Outdated Show resolved Hide resolved
@gitstream-cm
Copy link

gitstream-cm bot commented Oct 13, 2023

This PR is 21.52777777777778% new code.

@ArslanYM ArslanYM mentioned this pull request Oct 14, 2023
Closed
@gitstream-cm
Copy link

gitstream-cm bot commented Oct 15, 2023

🥷 Code experts: thelostone-mc

vacekj has most 👩‍💻 activity in the files.
thelostone-mc, vacekj have most 🧠 knowledge in the files.

See details

.github/PULL_REQUEST_TEMPLATE.md

Activity based on git-commit:

vacekj
OCT 21 additions & 5 deletions
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
vacekj: 66%

CONTRIBUTING.md

Activity based on git-commit:

vacekj
OCT
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
vacekj: 100%

README.md

Activity based on git-commit:

vacekj
OCT
SEP
AUG
JUL
JUN 14 additions & 5 deletions
MAY

Knowledge based on git-blame:
thelostone-mc: 76%
vacekj: 16%

packages/builder/README.md

Activity based on git-commit:

vacekj
OCT
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:

packages/round-manager/README.md

Activity based on git-commit:

vacekj
OCT
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
thelostone-mc: 75%
vacekj: 14%

To learn more about /:\ gitStream - Visit our Docs

@vacekj vacekj merged commit 159c34a into main Oct 17, 2023
10 checks passed
@vacekj vacekj deleted the 2431-update-contributingmd branch October 17, 2023 10:45
vacekj added a commit that referenced this pull request Oct 18, 2023
@vacekj @bard
docs: update contributing docs (#2440)
1232a04 
Co-authored-by: Massimiliano Mirra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhargavaparoksham bhargavaparoksham bhargavaparoksham approved these changes

@bard bard bard approved these changes

@gravityblast gravityblast gravityblast approved these changes

@boudra boudra Awaiting requested review from boudra

Assignees
No one assigned
Labels
5 min review missing-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs : update the steps in Dev.md as per .env.example Update contributing.md
4 participants
@vacekj @gravityblast @bard @bhargavaparoksham