Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect token name on Donation History page #2447

Merged
merged 3 commits into from
Oct 13, 2023
Merged

fix incorrect token name on Donation History page #2447

merged 3 commits into from
Oct 13, 2023

Conversation

bhargavaparoksham
Copy link
Contributor

@bhargavaparoksham bhargavaparoksham commented Oct 12, 2023 •
edited
Loading

Description

Fix incorrect token name on Donation History page

Refers/Fixes

fixes #2394

@bhargavaparoksham bhargavaparoksham requested review from a team as code owners October 12, 2023 13:47
@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 2:35pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 2:35pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 2:35pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 2:35pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 2:35pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 2:35pm

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 12, 2023

🥷 Code experts: no user but you matched threshold 10

bhargavaparoksham has most 👩‍💻 activity in the files.
bhargavaparoksham has most 🧠 knowledge in the files.

See details

packages/grant-explorer/src/features/contributors/DonationsTable.tsx

Activity based on git-commit:

bhargavaparoksham
OCT
SEP
AUG 133 additions & 0 deletions
JUL
JUN
MAY

Knowledge based on git-blame:
bhargavaparoksham: 98%

packages/grant-explorer/src/features/contributors/ViewContributionHistory.tsx

Activity based on git-commit:

bhargavaparoksham
OCT
SEP
AUG 8 additions & 154 deletions
JUL
JUN 998 additions & 704 deletions
MAY

Knowledge based on git-blame:
bhargavaparoksham: 94%

To learn more about /:\ gitStream - Visit our Docs

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 12, 2023

This PR is 76.92307692307693% new code.

michellema1208
michellema1208 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@michellema1208 michellema1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you Bhargav for quick turnaround here!!

@bhargavaparoksham bhargavaparoksham merged commit 8a162ad into main Oct 13, 2023
4 checks passed
@bhargavaparoksham bhargavaparoksham deleted the bug-2394 branch October 13, 2023 13:13
vacekj pushed a commit that referenced this pull request Oct 18, 2023
@bhargavaparoksham @vacekj
fix incorrect token name on Donation History page (#2447)
75333c3 
* fix: incorrect token name bug in donations page

* fix: other token name issues

* fix: token name issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellema1208 michellema1208 michellema1208 approved these changes

@boudra boudra boudra approved these changes

Assignees
No one assigned
Labels
1 min review missing-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explorer: Some donations on Donation History page are showing up in MATIC
3 participants
@bhargavaparoksham @boudra @michellema1208