Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove REACT_APP_DIRECT_GRANT_ENABLED and make it the default #2465

Merged
merged 3 commits into from
Oct 18, 2023
Merged

chore: remove REACT_APP_DIRECT_GRANT_ENABLED and make it the default #2465

merged 3 commits into from
Oct 18, 2023

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Oct 16, 2023 •
edited
Loading

PR checklist

For every PR, make sure that these statements are true:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't contain type casts and non-null assertions.
  • Doesn't add @ts-ignore.
  • Doesn't disable lints.
  • Doesn't use useState just for computation - use plain variables instead.
  • Splits components into pure components that don't depend on external state or hooks.
  • Avoid embedding components within other components
  • Doesn't propagate optional values without good reason, doesn't mark property values as optional if that doesn't represent reality.
  • Doesn't duplicate existing code.
  • Parses out-of-domain data - this includes user input, API respones, on-chain data etc.
  • Doesn't contain commented out code.
  • Doesn't contain skipped or empty tests.

Subjective - at the discretion of the reviewers

  • Does things as simply as possible, but not simpler.
  • Doesn't reinvent the wheel or create premature abstractions.
Refers/Fixes

fixes #2425

@vacekj vacekj linked an issue Oct 16, 2023 that may be closed by this pull request
remove the REACT_APP_DIRECT_GRANT_ENABLED and enable it by default #2425
Closed
@vacekj vacekj requested review from a team as code owners October 16, 2023 20:14
@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:32am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:32am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:32am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:32am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:32am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:32am

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 16, 2023

🥷 Code experts: bhargavaparoksham

vacekj, bhargavaparoksham have most 👩‍💻 activity in the files.
bhargavaparoksham, vacekj have most 🧠 knowledge in the files.

See details

packages/round-manager/.env.example

Activity based on git-commit:

vacekj bhargavaparoksham
OCT 47 additions & 22 deletions
SEP 40 additions & 0 deletions
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
vacekj: 100%

packages/round-manager/src/features/program/ViewProgramPage.tsx

Activity based on git-commit:

vacekj bhargavaparoksham
OCT 357 additions & 134 deletions
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
bhargavaparoksham: 72%
vacekj: 12%

To learn more about /:\ gitStream - Visit our Docs

@vacekj vacekj requested review from gravityblast, bard and boudra and removed request for a team October 17, 2023 10:57
boudra
boudra previously approved these changes Oct 17, 2023
View reviewed changes
@vacekj vacekj dismissed stale reviews from boudra, bard, and bhargavaparoksham via eeb308e October 18, 2023 09:30
@gitstream-cm
Copy link

gitstream-cm bot commented Oct 18, 2023

This PR is 40.298507462686565% new code.

2 similar comments
@gitstream-cm
Copy link

gitstream-cm bot commented Oct 18, 2023

This PR is 40.298507462686565% new code.

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 18, 2023

This PR is 40.298507462686565% new code.

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 18, 2023

This PR is 40.298507462686565% new code.

@vacekj vacekj merged commit 2f55a63 into main Oct 18, 2023
13 checks passed
@vacekj vacekj deleted the 2425-remove-the-react_app_direct_grant_enabled-and-enable-it-by-default branch October 18, 2023 13:04
vacekj added a commit that referenced this pull request Oct 18, 2023
@vacekj
chore: remove REACT_APP_DIRECT_GRANT_ENABLED and make it the default (#…
0714bfc 
…2465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boudra boudra boudra approved these changes

@bard bard bard approved these changes

@gravityblast gravityblast Awaiting requested review from gravityblast

@bhargavaparoksham bhargavaparoksham Awaiting requested review from bhargavaparoksham

Assignees
No one assigned
Labels
5 min review missing-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove the REACT_APP_DIRECT_GRANT_ENABLED and enable it by default
4 participants
@vacekj @bard @boudra @bhargavaparoksham