Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't display matching estimates for polygon #2656

Merged

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Nov 20, 2023

PR checklist

For every PR, make sure that these statements are true:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't contain type casts and non-null assertions.
  • Doesn't add @ts-ignore.
  • Doesn't disable lints.
  • Doesn't use useState just for computation - use plain variables instead.
  • Splits components into pure components that don't depend on external state or hooks.
  • Avoid embedding components within other components
  • Doesn't propagate optional values without good reason, doesn't mark property values as optional if that doesn't represent reality.
  • Doesn't duplicate existing code.
  • Parses out-of-domain data - this includes user input, API respones, on-chain data etc.
  • Doesn't contain commented out code.
  • Doesn't contain skipped or empty tests.
  • If this PR adds/updates any feature, it adds/updates its test script

Subjective - at the discretion of the reviewers

  • Does things as simply as possible, but not simpler.
  • Doesn't reinvent the wheel or create premature abstractions.
Description
Refers/Fixes

fixes #2655

@vacekj vacekj requested review from a team as code owners November 20, 2023 20:49
@vacekj vacekj linked an issue Nov 20, 2023 that may be closed by this pull request
Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 9:10pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 9:10pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 9:10pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 9:10pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 9:10pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 9:10pm

@michellema1208
Copy link
Contributor

Screen Shot 2023-11-20 at 3 52 56 PM

@vacekj hmm I'm still seeing $0 matching in the UI when donations are entered!

@michellema1208
Copy link
Contributor

@vacekj it looks like the explorer build failed btw!

@vacekj
Copy link
Contributor Author

vacekj commented Nov 20, 2023

@michellema1208 tired atris :D should be good now. if not, @bhargavaparoksham can fix.

Copy link

gitstream-cm bot commented Nov 20, 2023

🥷 Code experts: bhargavaparoksham

vacekj, bhargavaparoksham have most 👩‍💻 activity in the files.
vacekj, bhargavaparoksham have most 🧠 knowledge in the files.

See details

packages/grant-explorer/src/features/round/ViewCartPage/RoundInCart.tsx

Activity based on git-commit:

vacekj bhargavaparoksham
NOV
OCT 114 additions & 25 deletions 5 additions & 11 deletions
SEP 2 additions & 2 deletions
AUG 52 additions & 0 deletions
JUL
JUN

Knowledge based on git-blame:
vacekj: 78%
bhargavaparoksham: 22%

packages/grant-explorer/src/features/round/ViewCartPage/SummaryContainer.tsx

Activity based on git-commit:

vacekj bhargavaparoksham
NOV
OCT 91 additions & 15 deletions 5 additions & 11 deletions
SEP 13 additions & 7 deletions
AUG 11 additions & 16 deletions 368 additions & 0 deletions
JUL
JUN

Knowledge based on git-blame:
bhargavaparoksham: 77%
vacekj: 22%

packages/grant-explorer/src/hooks/matchingEstimate.ts

Activity based on git-commit:

vacekj bhargavaparoksham
NOV
OCT 87 additions & 0 deletions
SEP
AUG
JUL
JUN

Knowledge based on git-blame:
vacekj: 98%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Nov 20, 2023

This PR is 86.36363636363636% new code.

@melissa-neira melissa-neira merged commit e01d14c into main Nov 21, 2023
13 checks passed
@melissa-neira melissa-neira deleted the 2655-disable-polygon-matching-estimates-temporarily branch November 21, 2023 10:24
andremury pushed a commit to show-karma/grants-stack that referenced this pull request Nov 21, 2023
* feat: don't display matching estimates for polygon

* feat: don't display matching estimates for polygon

* feat: don't display matching estimates for polygon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled polygon matching estimates temporarily
5 participants