Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KARMA-GAP] Small fixes on the grants completion badge #3722

Merged

Conversation

fabianferno
Copy link
Contributor

Fixes: Check if grant was completed before checking for milestone completion

Description

Fixes on the Karma-GAP grant integration

  • Added completed type to a grant object
  • Check if grant was completed along with checking for milestone completion in the grant completion badge

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 1:27pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 1:27pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 1:27pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 1:27pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 1:27pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 1:27pm

@fabianferno
Copy link
Contributor Author

Example: https://explorer-git-fork-show-karma-fix-gap-milest-153022-grants-stack.vercel.app/#/round/42161/608/154

Previously, the system only checked if all milestones were completed. This PR updates the logic to check if the grant has been explicitly marked as complete by the user, ensuring accurate status updates.

@MasterHW MasterHW merged commit a3424aa into gitcoinco:main Nov 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants