Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
* https://github.com/j6t/git-gui:
  git gui: add directly calling merge tool from configuration
  git-gui: strip commit messages less aggressively
  git-gui: strip comments and consecutive empty lines from commit messages
  • Loading branch information
gitster committed Nov 11, 2024
2 parents facbe4f + e503389 commit b31fb63
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 3 deletions.
11 changes: 10 additions & 1 deletion git-gui/lib/commit.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,17 @@ You must stage at least 1 file before you can commit.

# -- A message is required.
#
set msg [string trim [$ui_comm get 1.0 end]]
set msg [$ui_comm get 1.0 end]
# Strip trailing whitespace
regsub -all -line {[ \t\r]+$} $msg {} msg
# Strip comment lines
regsub -all {(^|\n)#[^\n]*} $msg {\1} msg
# Strip leading empty lines
regsub {^\n*} $msg {} msg
# Compress consecutive empty lines
regsub -all {\n{3,}} $msg "\n\n" msg
# Strip trailing empty line
regsub {\n\n$} $msg "\n" msg
if {$msg eq {}} {
error_popup [mc "Please supply a commit message.
Expand Down
21 changes: 19 additions & 2 deletions git-gui/lib/mergetool.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,25 @@ proc merge_resolve_tool2 {} {
}
}
default {
error_popup [mc "Unsupported merge tool '%s'" $tool]
return
set tool_cmd [get_config mergetool.$tool.cmd]
if {$tool_cmd ne {}} {
if {([string first {[} $tool_cmd] != -1) || ([string first {]} $tool_cmd] != -1)} {
error_popup [mc "Unable to process square brackets in \"mergetool.%s.cmd\" configuration option.
Please remove the square brackets." $tool]
return
} else {
set cmdline {}
foreach command_part $tool_cmd {
lappend cmdline [subst -nobackslashes -nocommands $command_part]
}
}
} else {
error_popup [mc "Unsupported merge tool '%s'.
To use this tool, configure \"mergetool.%s.cmd\" as shown in the git-config manual page." $tool $tool]
return
}
}
}

Expand Down

0 comments on commit b31fb63

Please sign in to comment.