Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly unset proxy env if empty #2741

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Properly unset proxy env if empty #2741

merged 1 commit into from
Jan 29, 2025

Conversation

marcogario
Copy link
Contributor

@marcogario marcogario commented Jan 29, 2025

#2733 did not work correctly for Java because the CLI was expecting the environment variables to be unset and not just empty.

While we make the CLI more permissive, this PR re-introduces the changes in #2733 and patches the analyze action to unset those variables.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@marcogario marcogario marked this pull request as ready for review January 29, 2025 11:39
@Copilot Copilot bot review requested due to automatic review settings January 29, 2025 11:39
@marcogario marcogario requested a review from a team as a code owner January 29, 2025 11:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/start-proxy-action.ts:103

  • This new code path for empty credentials should have corresponding test coverage to ensure it returns early as expected.
  if (credentials.length === 0) {

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@marcogario marcogario merged commit 797fb30 into main Jan 29, 2025
525 checks passed
@marcogario marcogario deleted the reset_proxy_envs branch January 29, 2025 12:23
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants