Rust: Implement basic type inference in QL #18632
Draft
+2,996
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
rust/type-inference
branch
4 times, most recently
from
66bea42 to
2d0e953
Compare
hvitved
force-pushed
the
rust/type-inference
branch
7 times, most recently
from
c88c9fe to
a8540b1
Compare
hvitved
force-pushed
the
rust/type-inference
branch
3 times, most recently
from
02184af to
4f723dd
Compare
hvitved
force-pushed
the
rust/type-inference
branch
6 times, most recently
from
486f813 to
a254679
Compare
| @@ -27,6 +27,13 @@ | |||
| class RecordExpr extends Generated::RecordExpr { | |||
| override string toString() { result = this.getPath().toString() + " {...}" } | |||
|
|
|||
| /** Gets the record expression for the field `field`. */ | |||
| pragma[nomagic] | |||
| RecordExprField getFieldExpr(string name) { | |||
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
rust/type-inference
branch
3 times, most recently
from
42e5970 to
be2ec0f
Compare
hvitved
force-pushed
the
rust/type-inference
branch
from
5a1567c to
3f1a6c3
Compare
| // | ||
| // We get that the type path "0" resolves to `T1` for the `impl` block, | ||
| // which is considered a base type mention of `S`. | ||
| exists(PathMention selfPath, PathMention p, TypeParameter tp, int i | |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
Comment on lines
+510
to
+519
| exists(int i | | ||
| result = path.getPart().getGenericArgList().getTypeArgument(i) and | ||
| tp = resolvePath(path).getTypeParam(i) | ||
| ) | ||
| or | ||
| exists(ImplItemNode i, Function f, TypeParam mid | | ||
| result = getExplicitTypeArgMention(path.getQualifier(), mid) and | ||
| f = resolvePath(path) and | ||
| f = i.getAnAssocItem() | ||
| ) |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct. Warning
| tp = resolvePath(path).getTypeParam(i) | ||
| ) | ||
| or | ||
| exists(ImplItemNode i, Function f, TypeParam mid | |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
hvitved
force-pushed
the
rust/type-inference
branch
from
3f1a6c3 to
54ae28d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.