JS: Update test suite to use post-processed inline expectations #18670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
force-pushed
the
js/test-suite
branch
4 times, most recently
from
6e464f3 to
3a86b71
Compare
Some OK-style comments had to be moved to the following line, shifting line numbers. In selected range also included the comments themselves. Lastly, the result sets were reordered by the CLI in some cases.
This is expected, based on a comment earlier in the file about the 'y' variable
Diff looks confusing but:
Previously parameter {2,3} where flagged, now parameter {1,2} are flagged.
TS decorators may not appear on functions and enums
Line breaks used for more precise Alert marker
This reverts commit 02e8959.
This reverts commit 57d6d74.
With this query it's hard to say what's TP/FP as it's rather opinionated.
The presence of a syntax error sometimes prevents us from parsing the inline comment correctly.
This file was added on main while this branch was in progress. Porting the whole file in one step.
…mandConstruction)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| JSDoc/BadParamTag.ql | |||
| query: JSDoc/BadParamTag.ql | |||
Check warning
Code scanning / CodeQL
Query test without inline test expectations Warning test
| @@ -1 +1 @@ | |||
| LanguageFeatures/SyntaxError.ql | |||
| query: LanguageFeatures/SyntaxError.ql | |||
Check warning
Code scanning / CodeQL
Query test without inline test expectations Warning test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.