Upgrade cargo dependencies #18789
Open
Upgrade cargo dependencies #18789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 97 out of 97 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
redsun82
added
the
depends on internal PR
redsun82
removed
the
depends on internal PR
Merged
redsun82
force-pushed
the
redsun82/cargo-upgrade
branch
from
fd0aadf to
7e0f05f
Compare
redsun82
added
the
depends on internal PR
esbena
previously approved these changes
Feb 25, 2025
Comment on lines
+38
to
+40
| RUST_EDITION = "2024" | ||
|
|
||
| RUST_VERSION = "1.82.0" | ||
| RUST_VERSION = "1.85.0" |
There was a problem hiding this comment.
I'm assuming this is the only human edit in the PR.
There was a problem hiding this comment.
not really, as there were a couple of compilation errors to fix, but I understand the confusion, so I've chopped up the PR in individual more digestible commits, which should make it clear now what was done.
tausbn
previously approved these changes
Feb 25, 2025
added 8 commits
February 25, 2025 13:16
redsun82
force-pushed
the
redsun82/cargo-upgrade
branch
from
099311a to
bfcf9ea
Compare
redsun82
force-pushed
the
redsun82/cargo-upgrade
branch
2 times, most recently
from
a1a5cad to
d9ecb62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-analyzeralso requires a newer rustc, and switching to edition 2024. We could have different editions per crate, but I preferred to upgrade all of them.