-
Notifications
You must be signed in to change notification settings - Fork 60.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change git clone commands for wiki editing to not use https #36151
base: main
Are you sure you want to change the base?
Conversation
Since you cannot actually push changes to your wiki if you use https, the clone command should not instruct you to use https when cloning.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
👓 Previews for changed contentThis comment is 🤖 automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server |
@@ -45,7 +45,7 @@ Wikis can display PNG, JPEG, and GIF images. | |||
|
|||
You can link to an image in a repository on {% data variables.product.github %} by copying the URL in your browser and using that as the path to the image. For example, embedding an image in your wiki using Markdown might look like this: | |||
|
|||
[[https://github.com/USERNAME/REPOSITORY/blob/main/img/octocat.png|alt=octocat]] | |||
[[git@github.com:USERNAME/REPOSITORY/blob/main/img/octocat.png|alt=octocat]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FredrIQ, and thanks for your submission
Did you suggest editing the right page? It looks like you may have meant to suggest edits to https://docs.github.com/en/communities/documenting-your-project-with-wikis/adding-or-editing-wiki-pages?
Additionally, I've just tested and I'm able to push changes to a wiki using HTTPS, so I'm not sure the docs are incorrect here. Is it possible something else has happened with your configuration? If so, this wouldn't be the best place to get support, but I'm happy to leave this open for now in case there is in fact a problem with the docs I'm not seeing
Since you cannot actually push changes to your wiki if you use https, the clone command should not instruct you to use https when cloning.
Why:
Closes: #36150
What's being changed (if available, include any code snippets, screenshots, or gifs):
I changed https://github.com/github/docs/blob/main/content/communities/documenting-your-project-with-wikis/adding-or-editing-wiki-pages.md to suggest cloning with SSH instead of HTTPS
Check off the following: