Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Hacktoberfest topic #4042

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

MattIPv4
Copy link
Contributor

@MattIPv4 MattIPv4 commented Nov 14, 2023

Please confirm this pull request meets the following requirements:

I do work at DigitalOcean and am on the core Hacktoberfest team, but per #3885 (comment) I'm clear to check this checkbox.

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

I raised some concerns about recent changes to this topic over in #3995 (comment), with the tl;dr being that linking out to all these other topics is likely going to be misleading/confusing to participants of Hacktoberfest, as none of these additional topics are endorsed or tracked by Hacktoberfest, so contributions to repositories using them may not be counted if they do not have the hacktoberfest topic itself. Further, most of the topics that were added here are essentially not used, with almost all returning less than 5 repositories in their results.

Please see each commit for further justification/explanation for the changes within.

With these changes made, the only remaining links out in the topic description are to the language filters -- the dropdown for this is right below the description on the topic page, so honestly I somewhat feel those links are also redundant, but I have left them in for now.

@MattIPv4 MattIPv4 requested a review from a team as a code owner November 14, 2023 16:01
These carry no weight in Hacktoberfest, are not widely used, and tend to be used by repositories that are going against the values of Hacktoberfest by encouraging low-effort PRs.

Further, the `hacktoberfest-status` topic itself is essentially not used, and only has 5 repositories using it.
These make little sense, as Hacktoberfest only tracks PRs submitted by contributors, not issues. If folks want to look at issues for Hacktoberfest, they should look at issues in repositories with the  topic, not the arbitrary  topic

For both topics, there are essentially no repositories using them, with both only returning 2 repositories in their results.
If users want to explore different programming languages for Hacktoberfest, they should look at opted-in repositories withe  topic and use GitHub's built-in tooling for filtering by language
These topics are not tracked by Hacktoberfest and will not opt a repository in. Including them on this topic page is very likely going to lead to confused contributors who end up contributing to repositories that do not have the correct topics to be opted-in
As with the year topics, these topics are not tracked by Hacktoberfest and do not opt-in a repository. Having them listed may likely lead to contributors looking at repositories that are not opted-in for Hacktoberfest, and then having their contributions not be counted.

Further, all the topics linked here are essentially unused, returning less than 5 repositories each in their results.
@MattIPv4 MattIPv4 force-pushed the hacktoberfest-cleanup branch from f302d4f to 745b70c Compare November 14, 2023 16:06
@MattIPv4
Copy link
Contributor Author

I think, if anything, the most useful thing to have in this topic description would be some guidance to folks on how to find a repository that they feel motivated and comfortable contributing to, and one that follows the values of Hacktoberfest (isn't encouraging low-effort PRs to cheat the system, like adding a name to a list, or submitting a random algorithm).

A great feature that is currently missing from GitHub is the ability to search issues filtered by repository topic -- it'd be lovely to be able to link out from this topic page to all open issues in a hacktoberfest repository, so that folks can quickly explore what they could work on, and ideally even link out specifically to good-first-issue issues in hacktoberfest repositories. GitHub search doesn't support topic filters on issue searches though, so this isn't possible for now.

@shaedrich
Copy link
Contributor

Yeah, I think, I went a little wild there 😅 But adding some guidance instead sounds like a great idea 👍🏻

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the simplification here. I added one (non-blocking) question on the last line.

topics/hacktoberfest/index.md Show resolved Hide resolved
@ahpook ahpook added this pull request to the merge queue Nov 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 28, 2023
@ahpook ahpook added this pull request to the merge queue Nov 28, 2023
Merged via the queue into github:main with commit 3661eea Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants