Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GENERATED column as part of PK: handling UPDATE scenario #1004

Closed
wants to merge 53 commits into from

Conversation

shlomi-noach
Copy link
Contributor

Resubmission of openark#26 from downstream, this PR further supports GENERATED columns as part of the PRIMARY KEY. It was previously impossible to update rows based on a PK GENERATED value; now it is.

Related: #1000

Support a complete ALTER TABLE statement in --alter
Initial commit: towards setting up a test suite

Signed-off-by: Shlomi Noach <[email protected]>
…original table, applying AUTO_INCREMENT value onto ghost table if applicable and user has not specified AUTO_INCREMENT in alter statement
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Copying AUTO_INCREMENT value to ghost table
Generated column as part of UNIQUE (or PRIMARY) KEY
Cut-over should wait for heartbeat lag to be low enough to succeed
All MySQL DBs limited to max 3 concurrent/idle connections
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
hooks: reporting GH_OST_ETA_SECONDS. ETA as part of migration context
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Only allow -switch-to-rbr when inspecting replica
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…sting chosen uniqueKeyColumns

Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach changed the title Pk change to json GENERATED column as part of PK: handling UPDATE scenario Jul 12, 2021
@timvaillancourt timvaillancourt added this to the v1.1.3 milestone Jul 12, 2021
@timvaillancourt timvaillancourt modified the milestones: v1.1.5, v1.1.6 Jun 23, 2022
@timvaillancourt timvaillancourt modified the milestones: v1.1.6, v1.1.7 Dec 7, 2023
@timvaillancourt timvaillancourt modified the milestones: v1.1.7, v1.1.8 Apr 8, 2024
@meiji163
Copy link
Contributor

I didn't realize this existed before I fixed the same thing in #1461, doh!

@meiji163 meiji163 closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants