Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql.yml #494

Merged
merged 7 commits into from
Jan 14, 2023
Merged

Create codeql.yml #494

merged 7 commits into from
Jan 14, 2023

Conversation

djdefi
Copy link
Member

@djdefi djdefi commented Jan 10, 2023

This repo used to run LGTM, which was deprecated.

@@ -1,5 +1,5 @@
source 'http://rubygems.org'
source "http://rubygems.org"

Check failure

Code scanning / CodeQL

Dependency download using unencrypted communication channel

Dependency source URL uses the unencrypted protocol HTTP. Use HTTPS instead.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jkl

@djdefi
Copy link
Member Author

djdefi commented Jan 11, 2023

Thanks for jumping in with fixes here @stoe !

@stoe
Copy link
Member

stoe commented Jan 12, 2023

Thanks for jumping in with fixes here @stoe !

No problem. Thanks for opening this in the first place, @djdefi

I just have no clue how to get that last one fixed, which drives me nuts... 😢

@djdefi
Copy link
Member Author

djdefi commented Jan 13, 2023

@stoe I wonder if we should even include this example app at all: https://github.com/github/platform-samples/tree/master/api/javascript/search

This project employs several authentication strategies to avoid rate limiting while using the GitHub Search API

This seems like a violation of our site policy, and not something we should be encouraging here in any case.

@stoe
Copy link
Member

stoe commented Jan 14, 2023

@djdefi, agreed.
Seems reasonable to remove this entirely.

Copy link
Member

@stoe stoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@djdefi djdefi merged commit 7bc27c0 into master Jan 14, 2023
@djdefi djdefi deleted the djdefi-codeql branch January 14, 2023 19:33
QUGL-98-06-15

This comment was marked as off-topic.

QUGL-98-06-15

This comment was marked as spam.

Scamreno

This comment was marked as spam.

Scamreno

This comment was marked as spam.

@3nassale7

This comment was marked as spam.

Scamreno

This comment was marked as spam.

Copy link

@Jhonatanbb Jhonatanbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internet_20241020_201629_119

@Jhonatanbb
Copy link

Internet_20241020_201629_99

Copy link

@nawajiahmad nawajiahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sikontol mampus kau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants