Merge pull request #3897 from github/github-action/bump-node-version

Bump Node version to v20.18.1
github · Jan 15, 2025 · 6cafa5d · 6cafa5d
2 parents 056e45a + 4607a45
commit 6cafa5d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/extensions/ql-vscode/package-lock.json b/extensions/ql-vscode/package-lock.json
diff --git a/extensions/ql-vscode/src/common/jsonl-reader.ts b/extensions/ql-vscode/src/common/jsonl-reader.ts
@@ -24,7 +24,12 @@ export async function readJsonlFile<T>(
   return new Promise((resolve, reject) => {
     const stream = createReadStream(path, { encoding: "utf8" });
     let buffer = "";
-    stream.on("data", async (chunk: string) => {
+    stream.on("data", async (chunk: string | Buffer) => {
+      if (typeof chunk !== "string") {
+        // This should never happen because we specify the encoding as "utf8".
+        throw new Error("Invalid chunk");
+      }
+
       const parts = (buffer + chunk).split(doubleLineBreakRegexp);
       buffer = parts.pop()!;
       if (parts.length > 0) {

diff --git a/extensions/ql-vscode/test/vscode-tests/no-workspace/query-results.test.ts b/extensions/ql-vscode/test/vscode-tests/no-workspace/query-results.test.ts
@@ -291,7 +291,7 @@ describe("query-results", () => {
         });
 
         const finished = new Promise((res, rej) => {
-          validSarifStream.addListener("close", res);
+          validSarifStream.addListener("close", () => res(undefined));
           validSarifStream.addListener("error", rej);
         });
 
@@ -357,7 +357,7 @@ describe("query-results", () => {
         });
 
         const finished = new Promise((res, rej) => {
-          invalidSarifStream.addListener("close", res);
+          invalidSarifStream.addListener("close", () => res(undefined));
           invalidSarifStream.addListener("error", rej);
         });