Merge pull request #302 from aeisenberg/aeisenberg/large-log

feat: Allow large log files to be opened externally
github · Mar 23, 2020 · b689e55 · b689e55
2 parents 0b56092 + eed85e9
commit b689e55
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/extensions/ql-vscode/CHANGELOG.md b/extensions/ql-vscode/CHANGELOG.md
@@ -58,7 +58,6 @@ hour for unauthenticated IPs.
 - Fix the automatic upgrading of CodeQL databases when using upgrade scripts from the workspace.
 - Allow removal of items from the CodeQL Query History view.
 
-
 ## 1.0.0 - 14 November 2019
 
 Initial release of CodeQL for Visual Studio Code.
diff --git a/extensions/ql-vscode/src/query-history.ts b/extensions/ql-vscode/src/query-history.ts
@@ -5,6 +5,7 @@ import { CompletedQuery } from './query-results';
 import { QueryHistoryConfig } from './config';
 import { QueryWithResults } from './run-queries';
 import * as helpers from './helpers';
+import { logger } from './logging';
 
 /**
  * query-history.ts
@@ -191,12 +192,26 @@ export class QueryHistoryManager {
 
   async handleShowQueryLog(queryHistoryItem: CompletedQuery) {
     if (queryHistoryItem.logFileLocation) {
+      const uri = vscode.Uri.parse(queryHistoryItem.logFileLocation);
       try {
-        await vscode.window.showTextDocument(vscode.Uri.parse(queryHistoryItem.logFileLocation), {
-          viewColumn: vscode.ViewColumn.Beside
+        await vscode.window.showTextDocument(uri, {
         });
       } catch (e) {
-        helpers.showAndLogErrorMessage(`Could not open log file ${queryHistoryItem.logFileLocation}`);
+        if (e.message.includes('Files above 50MB cannot be synchronized with extensions')) {
+          const res = await helpers.showBinaryChoiceDialog('File is too large to open in the editor, do you want to open exterally?');
+          if (res) {
+            try {
+              await vscode.commands.executeCommand('revealFileInOS', uri);
+            } catch (e) {
+              helpers.showAndLogErrorMessage(e.message);
+            }
+          }
+        } else {
+          helpers.showAndLogErrorMessage(`Could not open log file ${queryHistoryItem.logFileLocation}`);
+          logger.log(e.message);
+          logger.log(e.stack);
+        }
+
       }
     } else {
       helpers.showAndLogWarningMessage('No log file available');