Review comments

github · Apr 22, 2020 · e242a8f · e242a8f
1 parent ee591e8
commit e242a8f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/extensions/ql-vscode/src/cli.ts b/extensions/ql-vscode/src/cli.ts
@@ -617,10 +617,11 @@ export class CodeQLCliServer implements Disposable {
 
   /**
    * Gets information about queries in a query suite.
+   * @param suite The suite to resolve.
    * @param additionalPacks A list of directories to search for qlpacks before searching in `searchPath`.
    * @param searchPath A list of directories to search for packs not found in `additionalPacks`. If undefined,
    *   the default CLI search path is used.
-   * @returns A list of query files found
+   * @returns A list of query files found.
    */
   resolveQueriesInSuite(suite: string, additionalPacks: string[], searchPath?: string[]): Promise<string[]> {
     const args = ['--additional-packs', additionalPacks.join(path.delimiter)];

diff --git a/extensions/ql-vscode/src/definitions.ts b/extensions/ql-vscode/src/definitions.ts
@@ -3,7 +3,7 @@ import * as yaml from 'js-yaml';
 import * as tmp from 'tmp';
 import * as vscode from "vscode";
 import { decodeSourceArchiveUri, zipArchiveScheme } from "./archive-filesystem-provider";
-import { EntityValue, getResultSetSchema, LineColumnLocation, UrlValue, ColumnKindCode } from "./bqrs-cli-types";
+import { ColumnKindCode, EntityValue, getResultSetSchema, LineColumnLocation, UrlValue } from "./bqrs-cli-types";
 import { CodeQLCliServer } from "./cli";
 import { DatabaseItem, DatabaseManager } from "./databases";
 import * as helpers from './helpers';
@@ -23,7 +23,8 @@ const TEMPLATE_NAME = "selectedSourceFile";
 const SELECT_QUERY_NAME = "#select";
 
 enum KeyType {
-  DefinitionQuery, ReferenceQuery
+  DefinitionQuery = 'DefinitionQuery',
+  ReferenceQuery = 'ReferenceQuery',
 }
 
 function tagOfKeyType(keyType: KeyType): string {