Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage of the bump CLI workflow #3915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koesie10
Copy link
Member

This simplifies the bump-cli workflow by removing the need to specify replace or prepend and removes the need to specify a version. Instead, we use a TypeScript script that automatically determines these options:

  1. It retrieves the current latest supported version from supported_cli_versions.json
  2. It retrieves the latest CodeQL version from https://github.com/github/codeql-cli-binaries/releases
  3. If they have the same major and minor version, it replaces the version
  4. If they have a different major or minor version, it prepends the version

@koesie10 koesie10 marked this pull request as ready for review January 23, 2025 15:44
@Copilot Copilot bot review requested due to automatic review settings January 23, 2025 15:44
@koesie10 koesie10 requested a review from a team as a code owner January 23, 2025 15:44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

extensions/ql-vscode/scripts/bump-supported-cli-versions.ts:30

  • This line may throw an error if existingVersions is empty or not valid. Consider handling the case where existingVersions[0] is undefined or invalid before creating a SemVer object.
const latestSupportedVersion = new SemVer(existingVersions[0]);

extensions/ql-vscode/scripts/bump-supported-cli-versions.ts:12

  • [nitpick] This newly introduced function does not appear to have associated tests. Please add coverage to ensure that the version replacement and prepending logic works as intended.
async function bumpSupportedCliVersions() {

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants