-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add support for ignoring filepaths via micromatch globs #28
Merged
Wattenberger
merged 15 commits into
githubocto:main
from
hydrosquall:cameron.yick/feature/ignore-files-and-folders
Aug 17, 2021
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0c8f385
chore(deps): add minimatch for pattern matching
hydrosquall 2acdd5a
chore(tooling): set up unit tests
hydrosquall db1033a
feat: enabling filtering via excluded_globs param (Fix #21, Fix #27)
hydrosquall 3c64a7e
chore(build): add CI to run unit tests
hydrosquall fe02268
build(chore): update typechecker
hydrosquall 3343a6a
docs: update parameters in github action config for exclude_globs
hydrosquall 8b4ad8b
fix syntax error in action.yml
repo-visualizer 86ecc39
don't require root_path
repo-visualizer 264b40d
default path to ./ for fs methods
repo-visualizer cf2f11b
dont check root path for glob or path match
repo-visualizer 986fc25
dont check root path for glob or path match
repo-visualizer 35d3bd0
dont exclude paths on empty glob
repo-visualizer e30bbb1
ensure paths are relative in fs methods
repo-visualizer 6255064
ensure paths are relative in fs.statSync
repo-visualizer cd955d0
fix: specify paths relative to recursive instead of root
hydrosquall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: JS - Unit Tests | ||
|
||
on: push | ||
|
||
jobs: | ||
|
||
run-tests: | ||
name: Unit Tests | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Check out Git repository | ||
uses: actions/checkout@v2 | ||
|
||
- name: Set up Node.js | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: 14 | ||
|
||
- name: Install dependencies with caching | ||
uses: bahmutov/npm-install@v1 | ||
|
||
- name: Check types | ||
run: | | ||
yarn run typecheck | ||
- name: Run unit tests | ||
run: | | ||
yarn run test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
node_modules | ||
node_modules |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this also worked for paths but only if they were immediate children of
root_dir
(this is whypackage.json
worked, butsrc/package.json
did not. Rather than explain this nuance, I think it'll be simpler to just only use this config for folders, and nudge people towards mostly using globs instead.