-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes mention of only supporting Pageant #172
base: main
Are you sure you want to change the base?
Conversation
Let's leave it for now, I'm not 100% sure which portions of the SSH config GitKraken will respect. It should respect almost all of it when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, actually we might need to leave this for now. Clone for example is still on NodeGit only, so will only work with Putty over SSH. Unless that's no longer the case for and we support the built-in SSH for NodeGit as well? @relyss do you know if that's the case?
I've tried cloning an SSH URL with Local agent set up for OpenSSH and it worked fine 👍 |
@ianhattendorf @relyss I believe all remote actions are now using Git Executable correct? If so, can we remove the mention of only supporting Pageant now? |
There are still places that use NodeGit for remotes, mostly tied to launchpad, submodules, and remote management IIRC. It's just the most common ones that have been converted. /cc @julianmesa-gitkraken @AlexaXs to confirm, as they've been working on scoping out the last of the migration recently |
True, we are still using NodeGit credentials (See trace in remaining work to remove NodeGit.Cred down from |
I did a quick review of this page and did not see anything else outdated besides the following, which still may be partially true still. Should we leave this in for now until we fully migrate?