Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Workspaces will now show when created #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jjsilva4
Copy link
Contributor

@jjsilva4 jjsilva4 commented May 1, 2024

When creating a new Local Workspace, the app closes the create window. This creates confusion for the user because it's unclear if the Local Workspace was successfully created.

The Local Workspace should open and show for the user when created.

Repro steps:

  1. Navigate to New Tab view
  2. Create a Local Workspaces using "sync" option
  3. Hit create button
  4. End.

@jkelroy jkelroy requested review from jkelroy and removed request for jkelroy June 4, 2024 15:43
@jkelroy jkelroy assigned jkelroy and unassigned jkelroy Jun 4, 2024
@jkelroy
Copy link
Contributor

jkelroy commented Jun 4, 2024

test

@jjsilva4 jjsilva4 added this to the October refactor milestone Sep 25, 2024
@jkelroy
Copy link
Contributor

jkelroy commented Oct 10, 2024

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #217

#217

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants