Simplifies walkthrough state

gitkraken · Jan 27, 2025 · 2f303f2 · 2f303f2
1 parent 926b9c5
commit 2f303f2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/src/webviews/apps/home/components/onboarding.ts b/src/webviews/apps/home/components/onboarding.ts
@@ -31,7 +31,7 @@ export class GlOnboarding extends LitElement {
 	private _openWalkthroughButton!: GlButton;
 
 	override render(): unknown {
-		if (!this._state.showWalkthroughProgress) {
+		if (this._state.walkthroughProgress == null) {
 			return undefined;
 		}
 
@@ -71,7 +71,7 @@ export class GlOnboarding extends LitElement {
 	}
 
 	private onDismissWalkthrough() {
-		this._state.showWalkthroughProgress = false;
+		this._state.walkthroughProgress = undefined;
 		this.requestUpdate();
 		this._ipc.sendCommand(DismissWalkthroughSection);
 	}

diff --git a/src/webviews/home/homeWebview.ts b/src/webviews/home/homeWebview.ts
@@ -607,7 +607,7 @@ export class HomeWebviewProvider implements WebviewProvider<State, State, HomeWe
 	}
 
 	private getWalkthroughDismissed() {
-		return Boolean(this.container.storage.get('home:walkthrough:dismissed'));
+		return this.container.storage.get('home:walkthrough:dismissed') ?? false;
 	}
 
 	private getPreviewCollapsed() {
@@ -664,12 +664,13 @@ export class HomeWebviewProvider implements WebviewProvider<State, State, HomeWe
 			integrationBannerCollapsed: this.getIntegrationBannerCollapsed(),
 			integrations: integrations,
 			hasAnyIntegrationConnected: anyConnected,
-			walkthroughProgress: {
-				allCount: this.container.walkthrough.walkthroughSize,
-				doneCount: this.container.walkthrough.doneCount,
-				progress: this.container.walkthrough.progress,
-			},
-			showWalkthroughProgress: !this.getWalkthroughDismissed(),
+			walkthroughProgress: !this.getWalkthroughDismissed()
+				? {
+						allCount: this.container.walkthrough.walkthroughSize,
+						doneCount: this.container.walkthrough.doneCount,
+						progress: this.container.walkthrough.progress,
+				  }
+				: undefined,
 			previewEnabled: this.getPreviewEnabled(),
 			newInstall: getContext('gitlens:install:new', false),
 		};

diff --git a/src/webviews/home/protocol.ts b/src/webviews/home/protocol.ts
@@ -28,12 +28,11 @@ export interface State extends WebviewState {
 	integrations: IntegrationState[];
 	avatar?: string;
 	organizationsCount?: number;
-	walkthroughProgress: {
+	walkthroughProgress?: {
 		doneCount: number;
 		allCount: number;
 		progress: number;
 	};
-	showWalkthroughProgress?: boolean;
 	previewEnabled: boolean;
 	newInstall: boolean;
 }