Fix repo names for Bitbucket (Server) #20264
Open
+57
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Oct 2, 2024
| @@ -285,7 +285,7 @@ export class BitbucketServerContextParser extends AbstractContextParser implemen | |||
| defaultBranch: BitbucketServer.Branch, | |||
| ): Repository { | |||
| const owner = repo.project.owner ? repo.project.owner.slug : repo.project.key; | |||
| const name = repo.name; | |||
| const name = repo.slug; | |||
There was a problem hiding this comment.
this is the fix for the BBS bug
filiptronicek
commented
Oct 2, 2024
There was a problem hiding this comment.
Looking forward to removing more of these in the future, but removed this one here because of the slug removals preventing compilation of this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was looking into ENT-724 and stumbled upon a bug with Bitbucket Server: when we resolve the context of a BBS URL, we take the
.namefrom the response and use that for subsequent API requests as part of the URL (fetch/{user}/{name}/resource). The problem is that.nameis actually the human-readable label for repositories and not the URL part, so we needed to swap it with.slugto prevent these issues from happening.Additionally, when I was already changing names to slugs, I figured we could use the display name when importing repositories. Thus, I introduced
displayNameon the generalRepositoryinterface to let compatible providers (BB and BBS AFAIK) feed us with something more human-readable for our default configuration names.Furthermore, I removed
slugfromCreateProjectParamsas we didn't use it anywhere and don't expose that to anyone.Fixes ENT-850
How to test
Import the following repos and check out their default names:
Wassup homies)Spring Petclinic)Check out the tests for a conclusive update in behavior. You need a bunch of setup and config for tests to work, so these are the results I can share when running against b7c832f: