Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targetix #71

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Targetix #71

wants to merge 5 commits into from

Conversation

atuldeshpande
Copy link
Collaborator

This adds the ability to specify target indices using a variable array targetix instead of running GLG tests for all genes as targets. This will allow users to query top regulators of a specific gene, or query the interactions in a small set of regulator and target genes in combination with the regix variable array.

atuldeshpande and others added 2 commits September 21, 2022 12:34
…, that the rankings of the edges and genes will be restricted to the subnetwork of genes corresponding to regix and targetix, and should be interpreted in that context.
Rebasing targetix to match current master
Copy link
Member

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the main readme to describe the new optional targetix. Even if we don't add a full test case, it would also be good idea to make a copy of data1 with the targetix set showing how to use it, for example adding a new X_targetix_test.mat.

I'll work on updating the Docker image to see if our test cases still pass with this version of the code.

if iscolumn(targetix)
targetix = targetix';
elseif ~isrow(targetix)
display('Error: Regulator indices must be a vector');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to stop execution here instead of only displaying a message? Or notify the user we are using all genes because their target index was improperly formatted? Currently we won't hit the code in the else block that sets the target index to be all genes.

Also, I believe we want to say "Target indices" not "Regulator indices".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to Target indices. I think it's best to error out here especially if this were to use expensive compute resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants