Remove redundant to_str() conversion
#2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acuteenvy thanks for following this up! Are you interested in participating more in gituis development? I am in the process of migrating it into its own org - would you join our discord? |
|
Sure, I'll join, but I probably won't be very active there as I rarely use discord. As for participating more, well, I'll try to send a PR every once in a while, but I don't wanna make any promises. Thanks for the invitation though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously used function could only take
&stras its argument, and I blindly copied it over here. This should've been part of #2524, sorry.I followed the checklist:
make checkwithout errors