Add option to enable authentication using Bearer tokens #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirkrypt0
force-pushed
the
feature/bearer-authentication
branch
2 times, most recently
from
8015ff9
to
c38c506
Compare
sirkrypt0
force-pushed
the
feature/bearer-authentication
branch
from
c38c506
to
08898bd
Compare
By enabling the `bearerEnabled` setting, authentication on the metrics endpoint using valid Bearer tokens can now be enforced. A client requesting the metrics endpoint must set the `Authorization: Bearer` header with a valid token obtained from Keycloak. The token must originate from the realm configured by the `realm` setting (defaults to `master`) and must have the role configured in the `role` setting (defaults to `prometheus-metrics`).
Security should be enabled by default in projects. We hence enforce that any of the available authentication options are configured before delivering the metrics as a response. If none of the authentication options are viable, authentication can be disabled all together, although that is surely not recommended.
sirkrypt0
force-pushed
the
feature/bearer-authentication
branch
from
08898bd
to
655893e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By enabling the
bearerEnabledsetting, authentication on the metricsendpoint using valid Bearer tokens can now be enforced. A client requesting
the metrics endpoint must set the
Authorization: Bearerheader with a validtoken obtained from Keycloak. The token must originate from the realm configured
by the
realmsetting (defaults tomaster) and must have the role configuredin the
rolesetting (defaults toprometheus-metrics).