-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bs feature branch #557
Open
bshmu
wants to merge
16
commits into
gizatechxyz:develop
Choose a base branch
from
bshmu:bs-feature-branch
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelDkhn
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bshmu, thanks for your PR!
Some things are missing to make the PR valid.
Please follow this step-by-step tutorial, to see how to implement operators in Orion:
https://orion.gizatech.xyz/academy/tutorials/implement-new-operators-in-orion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Adds a directory within operators to hold all MutMatrix related logic.
MutMatrix is updated with to_tensor() and from_tensor() methods to call tensor objects methods on the MutMatrix object. Some tensor methods (e.g. reshape, transpose, matmul, reduce_sum) are added to MutMatrix implementation.
Two new traits/impls for MutMatrix are added:
Tests are added and all imports using MutMatrix (e.g. TreeEnsembleClassifier) are updated accordingly.
Does this introduce a breaking change?