Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: numpy>2 casting of ints #266

Closed
wants to merge 2 commits into from
Closed

Conversation

fkroeber
Copy link

Implements #260, solution proposed by @fgassert

@fgassert
Copy link

FYI there are two other spots that might need a similar treatment:

if not np.can_cast(type(asset_scale), dtype):

@fkroeber
Copy link
Author

fkroeber commented Feb 10, 2025

Thanks for pointing me to it @fgassert!

I have realised that the implementation requires further consideration. I am therefore moving the discussion back to the issues, closing the PR for now.

@fkroeber fkroeber closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants