AcceleratedBatchedMeshRaycast: use getVisibleAt
instead of drawInfo
object
#706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two questions:
It's necessary to create a way to get instances in use count (drawInfo.length). Is an
instancesCount
getter okay?The method
getVisibleAt
and propertyinstancesCount
(and other future methods) , may not exist if the user is using an older version of three.js. How would you prefer to proceed?Adding these methods to
BatchedMesh.prototype
?Change the minimum version of three.js?