Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'matcha' under 'tools' #170

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add 'matcha' under 'tools' #170

merged 2 commits into from
Jul 5, 2024

Conversation

michaeljones
Copy link
Contributor

@michaeljones michaeljones commented Jul 5, 2024

Matcha is gleam related but isn't a hex package and doesn't have a documentation page so I've taken the experimental step of allowing the 'docs_url' to be optional in the package tomls.

I've completely happy for this to be rejected if you want to keep things to just hex packages.

Edit: Added matcha under the tools section and sorted it alphabetically.

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! You've added it to the packages section, but it's not not a package.

You likely want the tools section instead

@michaeljones
Copy link
Contributor Author

Good point. I didn't process that aspect of it properly. Could have saved a little time 😅 I'll add it to tools and remove the optional stuff.

@michaeljones michaeljones changed the title Add 'matcha' package and allow docs_url to be optional Add 'matcha' under 'tools' Jul 5, 2024
@michaeljones michaeljones requested a review from lpil July 5, 2024 19:14
@michaeljones
Copy link
Contributor Author

Hmm, I think I did it wrong. Trying again...

@michaeljones
Copy link
Contributor Author

Ok, added it to the gleam code too now.

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lpil lpil merged commit 8aa9c60 into gleam-lang:main Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants