Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emel, gleam_synapses, and gleam_zlists #190

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Conversation

mrdimosthenis
Copy link
Contributor

  • Please let me know if you prefer a separate pull request for each package.
  • I placed emel and gleam_synapses under Data Structures instead of introducing a new Machine Learning category. If you think a new category is necessary, I would be happy to add it.

@lpil
Copy link
Member

lpil commented Sep 26, 2024

A new ML category sounds cool!

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a look and it seems like these libraries have not been updated in a long time and likely won't work with current Gleam versions. Have you tested them?

@mrdimosthenis
Copy link
Contributor Author

I just had a look and it seems like these libraries have not been updated in a long time and likely won't work with current Gleam versions. Have you tested them?

You are right. I will try to update them and get back to you once they work properly with the latest version of Gleam.

@mrdimosthenis
Copy link
Contributor Author

I just had a look and it seems like these libraries have not been updated in a long time and likely won't work with current Gleam versions. Have you tested them?

@lpil I updated all three libraries and tested them with gleam-version: "1.5.1".

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@lpil lpil merged commit 65efd28 into gleam-lang:main Sep 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants