implement big int module #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Aug 14, 2023
src/gleam/javascript/big_int.gleam
Outdated
| pub fn from_int(a: Int) -> BigInt | ||
|
|
||
| @external(javascript, "../../ffi.mjs", "from") | ||
| pub fn from_string(a: String) -> BigInt |
There was a problem hiding this comment.
How does this work? What happens when it's not a valid string?
There was a problem hiding this comment.
it errors. updated from_string to return result but from_int can still return just a value
lpil
reviewed
Aug 14, 2023
|
|
||
| big_int.add(a, b) | ||
| |> should.equal(big_int.from_string("18446744073709551617")) | ||
| } |
There was a problem hiding this comment.
Could we have tests for all the functions please 🙏
There was a problem hiding this comment.
Added for remaining functions
lpil
reviewed
Aug 18, 2023
Comment on lines
+24
to
+27
| /// Zero division returns an error, this is different to core gleam number type | ||
| /// and is chosen because this library aims to be smallest wrapper for ffi and | ||
| /// where possible should emulate platform behaviour | ||
| @external(javascript, "../../ffi.mjs", "divide") |
There was a problem hiding this comment.
In Gleam dividing by zero returns zero. Let's do that to be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.