Show more informative error when dynamic.dict fails #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Nov 17, 2024
test/gleam/dynamic_test.gleam
Outdated
| @@ -1132,14 +1132,14 @@ pub fn dict_test() { | |||
| |> dynamic.from | |||
| |> dynamic.dict(dynamic.int, dynamic.int) | |||
| |> should.equal( | |||
| Error([DecodeError(expected: "Int", found: "String", path: ["keys"])]), | |||
| Error([DecodeError(expected: "Int", found: "String", path: ["keys[0]"])]), | |||
There was a problem hiding this comment.
This isn't the syntax for indexing in this module, and you can't index into the keys with 0, they are not ordered.
There was a problem hiding this comment.
Hi
Not sure what do you mean with the syntax comment.
The values[1] is just meant to show the index of the failed input. Changed the test to reflect this.
The intention is to have some way to find the problematic input in the original data source.
e.g. given
{
"dog": { "id": 1 },
"cat": { "id": 2 },
"fish": { "id": null },
"rabbit": { "id": 4 },
}I will like to be able to see an error showing values[2] which points me to fish.
Not sure however if the index will be correct when parsing something like this.
There was a problem hiding this comment.
The indexing only works on erlang. We need a different strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#740
This makes the decoding error a bit more informative by showing the index of the failed value or key.
As the key can decode to anything (not necessarily a string). It is not possible to show the name of the key.