feat: Support more leading comment types #2482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2332
Summary
Updates comment types and allows
leadingComments
to support multiple comment types, addsemitComments
method in ConvenienceRendererChanges
emitComments
method in ConvenienceRenderer to handle different comment stylesemitCommentLines
method to take object as param instead of list argslineEnd
param toemitCommentLines
beforeLine
tobeforeComment
andafterLine
toafterComment
This change is backwards-compatible for all external/standard use cases as it preserves the existing
string[]
type forleadingComments
but it will break custom renderers that callemitCommentLines
directly