Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nicer datatable #424

Merged
merged 5 commits into from
Jun 8, 2022
Merged

feat: nicer datatable #424

merged 5 commits into from
Jun 8, 2022

Conversation

cooper667
Copy link
Contributor

@cooper667 cooper667 commented Jun 8, 2022

Description

Minor datatable changes, addresses some of #417 (which i only saw after doing them...it doesn't aim to solve all the points in that issue, just some of the easy wins/obviously broken parts)

  • It now works with sort/filter on the side bar (and removes those options from the columns)
  • Add some small typings
  • Move DataTable into new file to make ui.tsx very slightly neater
  • Hide 'multiselect' button when on table view
  • Disable thumbnail size on table view
  • minor polish on sort popover

One thing that isn't supported in DataTable is groupBy unless we give MUI the dollars. Not sure if we need a way in the UI to indicate that @joshuajames-smith ?

Created 2 follow on issues:

#423
#422

@gliff-ai-robot gliff-ai-robot added the feature [Improvement] New feature request. label Jun 8, 2022
@cooper667 cooper667 self-assigned this Jun 8, 2022
@cooper667 cooper667 enabled auto-merge (squash) June 8, 2022 04:16
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-424.westeurope.azurestaticapps.net

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2022

This pull request introduces 1 alert when merging 40b7ec4 into 6e366cf - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-424.westeurope.azurestaticapps.net

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2022

This pull request introduces 1 alert when merging 2f54795 into 5dd4641 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-424.westeurope.azurestaticapps.net

@cooper667 cooper667 disabled auto-merge June 8, 2022 07:49
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-424.westeurope.azurestaticapps.net

@cooper667
Copy link
Contributor Author

No percy?

@cooper667 cooper667 merged commit 1637970 into main Jun 8, 2022
@cooper667 cooper667 deleted the data_table_filters branch June 8, 2022 08:36
@joshuajames-smith
Copy link
Contributor

One thing that isn't supported in DataTable is groupBy unless we give MUI the dollars. Not sure if we need a way in the UI to indicate that @joshuajames-smith ?

@cooper667 we can just disabled or remove the checkbox to groupBy in the sort dialogue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [Improvement] New feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants