Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Project level audit #776

Open
wants to merge 35 commits into
base: staging
Choose a base branch
from
Open

feat: Project level audit #776

wants to merge 35 commits into from

Conversation

philipjackson
Copy link
Contributor

@philipjackson philipjackson commented Jul 28, 2022

Description

Adds ProjectAudit.ts and TeamAudit.ts in the interfaces directory. These define interfaces for logging project and team level audit actions. These interfaces are used in DominateStore to log project and team level audit actions in a consistent format.

Project and team level audits are implemented as collections. The project level audit's UID is stored in the gallery's metadata when the project is created (only currently works for newly created projects therefore). Team level audit is independent of any project and is created when logTeamActions is called for the first time. Team level audit was created to log user and collaborator invites and acceptance - these logs couldn't be stored in any project level audit because there's no way to meaningfully associate them with any particular project.

Depends on gliff-ai/curate#448

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

  • I have read the gliff.ai Contribution Guide.
  • I have requested to pull a branch and not from main.
  • I have checked all commit message styles match the requested structure.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my own code.
  • I have assigned 3 or less reviewers.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have made corresponding changes to the documentation.
  • New database changes have been committed.
  • If appropriate, I have bumped any version numbers.

@gliff-ai-robot gliff-ai-robot added the feature [Improvement] New feature request. label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [Improvement] New feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants